You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/02/11 18:44:15 UTC
[jira] [Commented] (ACTIVEMQ6-78) Performance Improvement over
Netty NIO Blocked calls
[ https://issues.apache.org/jira/browse/ACTIVEMQ6-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316619#comment-14316619 ]
ASF GitHub Bot commented on ACTIVEMQ6-78:
-----------------------------------------
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-6/pull/95
ACTIVEMQ6-78 performance improvements
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-6 perf
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-6/pull/95.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #95
----
commit 8b0063fd573f0b45c1da222ab9e538f65b3c66e7
Author: Clebert Suconic <cl...@apache.org>
Date: 2015-02-10T15:53:02Z
ACTIVEMQ6-78 Adding tests to evaluate this task
https://issues.apache.org/jira/browse/ACTIVEMQ6-78
This commit is just adding tests I used to debug the blocked calls issue
There are some profiling parameters you can use that I added as a comment to the pom
The reason this is a separate commit is that it could be easier to validate the results of optimizations
checking after and before any changes
commit 0a6edee8b58d3db9c3c063ab7c9b1bcd53ba427b
Author: Clebert Suconic <cl...@apache.org>
Date: 2015-02-10T16:30:18Z
ACTIVEMQ6-78 Improving performance over Netty NIO blocked calls
https://issues.apache.org/jira/browse/ACTIVEMQ6-78 performance work
There are two aspects of this work. First avoid asynchronous packets and avoid
context switch over the executors. Packet had a method to make certain packets such
as commit to use a different executor. Since it's NIO everything is done at the Netty thread now.
The second aspect was to make sure we use the proper buffering
commit 88f13f267f7a88b529fb7bfa7b6578dc62ef863c
Author: Clebert Suconic <cl...@apache.org>
Date: 2015-02-11T13:36:17Z
Fixing test failure
This test started to fail after performance improvements from ACTIVEMQ6-78
After some investigation it turned out that this test was racing with the client
crashing even before the queue was created or sending a non persistent message
asynchronously while the client crashed before the server received the message.
I've also decreased some of the times on pings so the test could run a bit faster
----
> Performance Improvement over Netty NIO Blocked calls
> ----------------------------------------------------
>
> Key: ACTIVEMQ6-78
> URL: https://issues.apache.org/jira/browse/ACTIVEMQ6-78
> Project: Apache ActiveMQ 6
> Issue Type: Improvement
> Affects Versions: 6.0.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Fix For: 6.0.0
>
>
> When we started using NIO blocked calls had a little regression because of the executors usage.
> This will be about fixing that and making sure about how we use buffers on parsing and sending packets.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)