You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "rohit-kb (via GitHub)" <gi...@apache.org> on 2023/05/10 13:50:58 UTC
[GitHub] [hadoop] rohit-kb opened a new pull request, #5639: HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code
rohit-kb opened a new pull request, #5639:
URL: https://github.com/apache/hadoop/pull/5639
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #5639: HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1559097933
ok, with the second option but your build is also failing with compilation error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] rohit-kb commented on pull request #5639: HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code
Posted by "rohit-kb (via GitHub)" <gi...@apache.org>.
rohit-kb commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1543289315
> Why this filter isn’t required in trunk?
Probably because of this dependency version:
```
<dependency>
<groupId>org.codehaus.mojo</groupId>
<artifactId>extra-enforcer-rules</artifactId>
<version>1.0-beta-3</version>
</dependency>
```
In trunk, the version is 1.5.1 and the upgrade is done in [HADOOP-18131](https://issues.apache.org/jira/browse/HADOOP-18131). This new version seems to have changes in enforcer rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #5639: HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code
Posted by "hadoop-yetus (via GitHub)" <gi...@apache.org>.
hadoop-yetus commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1542499086
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 7m 31s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available. |
| +0 :ok: | xmllint | 0m 1s | | xmllint was not available. |
| +0 :ok: | shelldocs | 0m 1s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ branch-3.3 Compile Tests _ |
| +0 :ok: | mvndep | 15m 45s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 23m 44s | | branch-3.3 passed |
| +1 :green_heart: | compile | 18m 11s | | branch-3.3 passed |
| +1 :green_heart: | mvnsite | 26m 14s | | branch-3.3 passed |
| +1 :green_heart: | javadoc | 7m 43s | | branch-3.3 passed |
| +1 :green_heart: | shadedclient | 35m 35s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 6m 27s | [/patch-mvninstall-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/1/artifact/out/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 0m 26s | [/patch-compile-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/1/artifact/out/patch-compile-root.txt) | root in the patch failed. |
| -1 :x: | javac | 0m 26s | [/patch-compile-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/1/artifact/out/patch-compile-root.txt) | root in the patch failed. |
| -1 :x: | blanks | 0m 0s | [/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/1/artifact/out/blanks-eol.txt) | The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -1 :x: | mvnsite | 0m 40s | [/patch-mvnsite-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/1/artifact/out/patch-mvnsite-root.txt) | root in the patch failed. |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| -1 :x: | javadoc | 1m 35s | [/patch-javadoc-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/1/artifact/out/patch-javadoc-root.txt) | root in the patch failed. |
| -1 :x: | shadedclient | 3m 30s | | patch has errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 5m 4s | [/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/1/artifact/out/patch-unit-root.txt) | root in the patch failed. |
| -1 :x: | asflicense | 0m 51s | [/results-asflicense.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/1/artifact/out/results-asflicense.txt) | The patch generated 1 ASF License warnings. |
| | | 159m 8s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/5639 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs |
| uname | Linux 8de93e424456 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.3 / 13c8fea0fe609f1ac37d09eda34367e9ba677e49 |
| Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~18.04.1-b09 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/1/testReport/ |
| Max. process+thread count | 550 (vs. ulimit of 5500) |
| modules | C: hadoop-project hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster . U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/1/console |
| versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #5639: HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code
Posted by "hadoop-yetus (via GitHub)" <gi...@apache.org>.
hadoop-yetus commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1562182695
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 35s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ branch-3.3 Compile Tests _ |
| +0 :ok: | mvndep | 26m 22s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 23m 43s | | branch-3.3 passed |
| +1 :green_heart: | compile | 17m 46s | | branch-3.3 passed |
| +1 :green_heart: | mvnsite | 25m 20s | | branch-3.3 passed |
| +1 :green_heart: | javadoc | 7m 2s | | branch-3.3 passed |
| +1 :green_heart: | shadedclient | 29m 59s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 34s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 30m 42s | | the patch passed |
| +1 :green_heart: | compile | 17m 26s | | the patch passed |
| +1 :green_heart: | javac | 17m 26s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | mvnsite | 20m 39s | | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | javadoc | 6m 41s | | the patch passed |
| +1 :green_heart: | shadedclient | 30m 7s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 689m 34s | [/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/3/artifact/out/patch-unit-root.txt) | root in the patch passed. |
| +1 :green_heart: | asflicense | 1m 40s | | The patch does not generate ASF License warnings. |
| | | 918m 16s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes |
| | hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery |
| | hadoop.hdfs.server.namenode.ha.TestHAAppend |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/5639 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs |
| uname | Linux b5780c582f46 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.3 / b2a3aca7b8e7ee1a9243b4cd83b94ce2f7b6e9bf |
| Default Java | Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/3/testReport/ |
| Max. process+thread count | 4131 (vs. ulimit of 5500) |
| modules | C: hadoop-project hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster . U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/3/console |
| versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] rohit-kb commented on pull request #5639: HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code
Posted by "rohit-kb (via GitHub)" <gi...@apache.org>.
rohit-kb commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1549443703
Actually, we have tried porting [HADOOP-18131](https://issues.apache.org/jira/browse/HADOOP-18131) to branch-3.3 previously and I checked it again too, but we were/are getting this compilation issue:
```
Dependency convergence error for log4j:log4j:jar:1.2.17:test paths to dependency are:
+-org.apache.hadoop:hadoop-yarn-server-timelineservice-documentstore:jar:3.3.9-SNAPSHOT
+-org.mockito:mockito-core:jar:2.8.9:test
+-net.bytebuddy:byte-buddy-agent:jar:1.6.14:test
+-com.kohlschutter.junixsocket:junixsocket-native-common:jar:2.0.4:test
+-com.kohlschutter.junixsocket:junixsocket-common:jar:2.0.4:test
+-log4j:log4j:jar:1.2.17:test
and
+-org.apache.hadoop:hadoop-yarn-server-timelineservice-documentstore:jar:3.3.9-SNAPSHOT
+-org.mockito:mockito-core:jar:2.8.9:test
+-net.bytebuddy:byte-buddy-agent:jar:1.6.14:test
+-com.kohlschutter.junixsocket:junixsocket-native-common:jar:2.0.4:test
+-log4j:log4j:jar:1.2.17:test
and
+-org.apache.hadoop:hadoop-yarn-server-timelineservice-documentstore:jar:3.3.9-SNAPSHOT
+-com.microsoft.azure:azure-cosmosdb:jar:2.4.5:compile
+-com.fasterxml.uuid:java-uuid-generator:jar:3.1.4:compile
+-log4j:log4j:jar:1.2.13:provided
```
It kind of comes down to **log4j** in **trunk** vs **reload4j** in **branch-3.3**. So, either we can try some exclusions/replacements while porting [HADOOP-18131](https://issues.apache.org/jira/browse/HADOOP-18131) or we can go with current filters in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]
Posted by "rohit-kb (via GitHub)" <gi...@apache.org>.
rohit-kb commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1767946931
Sure @pjfanning, will do, thanks for the info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #5639: HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code
Posted by "steveloughran (via GitHub)" <gi...@apache.org>.
steveloughran commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1547637611
well, you get to cherrypick that and any followups you can see off the jira. that's the way it goes I'm afraid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]
Posted by "rohit-kb (via GitHub)" <gi...@apache.org>.
rohit-kb closed pull request #5639: HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code
URL: https://github.com/apache/hadoop/pull/5639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #5639: HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code
Posted by "hadoop-yetus (via GitHub)" <gi...@apache.org>.
hadoop-yetus commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1560427173
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 7m 35s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ branch-3.3 Compile Tests _ |
| +0 :ok: | mvndep | 36m 26s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 24m 7s | | branch-3.3 passed |
| +1 :green_heart: | compile | 17m 53s | | branch-3.3 passed |
| +1 :green_heart: | mvnsite | 25m 14s | | branch-3.3 passed |
| +1 :green_heart: | javadoc | 7m 0s | | branch-3.3 passed |
| +1 :green_heart: | shadedclient | 30m 3s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 30m 59s | | the patch passed |
| +1 :green_heart: | compile | 17m 53s | | the patch passed |
| +1 :green_heart: | javac | 17m 53s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | mvnsite | 23m 13s | | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | javadoc | 6m 56s | | the patch passed |
| +1 :green_heart: | shadedclient | 30m 1s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 691m 43s | [/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/2/artifact/out/patch-unit-root.txt) | root in the patch passed. |
| +1 :green_heart: | asflicense | 1m 39s | | The patch does not generate ASF License warnings. |
| | | 941m 16s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerOvercommit |
| | hadoop.yarn.client.api.impl.TestAMRMClient |
| | hadoop.yarn.sls.TestReservationSystemInvariants |
| | hadoop.hdfs.server.federation.router.TestRouterWithSecureStartup |
| | hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints |
| | hadoop.hdfs.TestRollingUpgrade |
| | hadoop.hdfs.server.namenode.TestLargeDirectoryDelete |
| | hadoop.hdfs.tools.TestDFSZKFailoverController |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/5639 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs |
| uname | Linux eb4124b5fe03 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.3 / b2a3aca7b8e7ee1a9243b4cd83b94ce2f7b6e9bf |
| Default Java | Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/2/testReport/ |
| Max. process+thread count | 3159 (vs. ulimit of 5500) |
| modules | C: hadoop-project hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster . U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/2/console |
| versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]
Posted by "rohit-kb (via GitHub)" <gi...@apache.org>.
rohit-kb commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1768153646
@pjfanning my bad, kind of went a bit overboard while avoiding those blanks related checks assuming that these changes won't matter.
Also, a bit doubtful regarding the rebase, I did rebase these commits after taking a recent pull from branch-3.3 locally. Should I add a new commit entirely reflecting the recent date for this PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1846123497
#6201 was merged - this can be closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #5639: HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1542422438
Why this filter isn’t required in trunk?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] rohit-kb commented on pull request #5639: HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code
Posted by "rohit-kb (via GitHub)" <gi...@apache.org>.
rohit-kb commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1542258336
Added filters because of the following error during compilation:
`[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-banned-dependencies) @ hadoop-client-check-test-invariants ---
[INFO] Adding ignorable dependency: org.apache.hadoop:hadoop-annotations:null
[INFO] Adding ignore: *
[WARNING] Rule 1: org.apache.maven.plugins.enforcer.BanDuplicateClasses failed with message:
Duplicate classes found:
Found in:
org.apache.hadoop:hadoop-client-minicluster:jar:3.3.9-SNAPSHOT:compile
org.apache.hadoop:hadoop-client-runtime:jar:3.3.9-SNAPSHOT:compile
Duplicate classes:
META-INF/versions/9/module-info.class`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]
Posted by "hadoop-yetus (via GitHub)" <gi...@apache.org>.
hadoop-yetus commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1769575285
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 25s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ branch-3.3 Compile Tests _ |
| +0 :ok: | mvndep | 14m 33s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 22m 26s | | branch-3.3 passed |
| +1 :green_heart: | compile | 11m 56s | | branch-3.3 passed |
| +1 :green_heart: | mvnsite | 19m 25s | | branch-3.3 passed |
| +1 :green_heart: | javadoc | 5m 5s | | branch-3.3 passed |
| +1 :green_heart: | shadedclient | 27m 35s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 28s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 32m 48s | | the patch passed |
| +1 :green_heart: | compile | 11m 33s | | the patch passed |
| +1 :green_heart: | javac | 11m 33s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | mvnsite | 14m 58s | | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | javadoc | 4m 50s | | the patch passed |
| +1 :green_heart: | shadedclient | 27m 48s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 612m 37s | [/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/4/artifact/out/patch-unit-root.txt) | root in the patch passed. |
| +1 :green_heart: | asflicense | 1m 18s | | The patch does not generate ASF License warnings. |
| | | 801m 31s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdfs.tools.TestDFSAdmin |
| | hadoop.hdfs.server.datanode.TestDirectoryScanner |
| | hadoop.util.curator.TestZKCuratorManager |
| | hadoop.yarn.sls.TestReservationSystemInvariants |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/5639 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs |
| uname | Linux 5e824957dafc 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.3 / d3d24c6c647527c90982c6e6d02224ac0da71bcd |
| Default Java | Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/4/testReport/ |
| Max. process+thread count | 3245 (vs. ulimit of 5500) |
| modules | C: hadoop-project hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster . U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/4/console |
| versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] rohit-kb commented on pull request #5639: HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code
Posted by "rohit-kb (via GitHub)" <gi...@apache.org>.
rohit-kb commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1554375086
Hi @ayushtkn , following up on above comment, I think there are two options to proceed further:
1. One is to cherry-pick [HADOOP-18131](https://issues.apache.org/jira/browse/HADOOP-18131) but adding **log4j** exclusions due to **log4j** in **trunk** and **reload4j** in **branch-3.3**.
2. Another one is to retain the filters in this PR.
I was thinking of going with second one for the moment as the first one might complicate things further. Please provide your input on the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1768135406
@rohit-kb could you remove the edits to the 2 pom files? You have 4 edited files in this PR while you only need 2 (the ones that change the nimbus version). See https://github.com/apache/hadoop/pull/5573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1768160519
@rohit-kb I created https://github.com/apache/hadoop/pull/6201 - feel free to continue with this PR but I created 6201 just in case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1766712078
@rohit-kb could you rebase this? The issue with the module-info classes has recently been resolved in branch-3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org