You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/03/06 12:51:05 UTC
[GitHub] [submarine] lowc1012 opened a new pull request #203: SUBMARINE-375.
Ensure TF example code is supported in TensorFlow 2
lowc1012 opened a new pull request #203: SUBMARINE-375. Ensure TF example code is supported in TensorFlow 2
URL: https://github.com/apache/submarine/pull/203
### What is this PR for?
Because TensorFlow 2 removes many APIs, we should add a new tf2 example and reserve the tf1 example code
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
[SUBMARINE-375](https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-375)
### How should this be tested?
[passed CI](https://travis-ci.org/lowc1012/submarine/builds/659106327)
### Screenshots (if appropriate)
<img width="689" alt="螢幕快照 2020-03-06 下午7 19 03" src="https://user-images.githubusercontent.com/52355146/76079987-e22af300-5fe0-11ea-9e94-a14e895d3bf8.png">
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] lowc1012 commented on issue #203: SUBMARINE-375. Ensure
TF example code is supported in TensorFlow 2
Posted by GitBox <gi...@apache.org>.
lowc1012 commented on issue #203: SUBMARINE-375. Ensure TF example code is supported in TensorFlow 2
URL: https://github.com/apache/submarine/pull/203#issuecomment-596161235
@pingsutw @liuxunorg
Thanks for your review!
I will change it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #203:
SUBMARINE-375. Ensure TF example code is supported in TensorFlow 2
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #203: SUBMARINE-375. Ensure TF example code is supported in TensorFlow 2
URL: https://github.com/apache/submarine/pull/203#discussion_r388899026
##########
File path: dev-support/mini-submarine/submarine/run_submarine_mnist_tf2_tony.sh
##########
@@ -0,0 +1,59 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+while [ $# -gt 0 ]; do
+ case "$1" in
+ --debug*)
+ DEBUG=$1
+ if [ -n "$2" ]; then
+ DEBUG_PORT=$2
+ shift
+ fi
+ shift
+ ;;
+ *)
+ break
+ ;;
+ esac
+done
+
+if [ "$DEBUG" ]; then
+ if [ -z "$DEBUG_PORT" ]; then
+ DEBUG_PORT=8000
+ fi
+ JAVA_CMD="java -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=${DEBUG_PORT}"
+else
+ JAVA_CMD="java"
+fi
+
+SUBMARINE_VERSION=0.4.0-SNAPSHOT
+HADOOP_VERSION=2.9
+SUBMARINE_PATH=/opt/submarine-current
+HADOOP_CONF_PATH=/usr/local/hadoop/etc/hadoop
+
+${JAVA_CMD} -cp "$("${HADOOP_COMMON_HOME}"/bin/hadoop classpath --glob)":${SUBMARINE_PATH}/submarine-all-${SUBMARINE_VERSION}-hadoop-"${HADOOP_VERSION}".jar:${HADOOP_CONF_PATH} \
+ org.apache.submarine.client.cli.Cli job run --name tf-job-001 \
Review comment:
Thanks @lowc1012 for the contribution.
Overall LGTM. minor suggestion, could we change the name to `tf2-job-001`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #203: SUBMARINE-375.
Ensure TF example code is supported in TensorFlow 2
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #203: SUBMARINE-375. Ensure TF example code is supported in TensorFlow 2
URL: https://github.com/apache/submarine/pull/203#issuecomment-596154633
https://github.com/apache/submarine/pull/203#discussion_r388899026
@lowc1012 Can you change job name to `tf2-job-001` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #203: SUBMARINE-375. Ensure
TF example code is supported in TensorFlow 2
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #203: SUBMARINE-375. Ensure TF example code is supported in TensorFlow 2
URL: https://github.com/apache/submarine/pull/203
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org