You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by paul-rogers <gi...@git.apache.org> on 2018/01/18 05:17:12 UTC
[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162229669
--- Diff: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcBatchCreator.java ---
@@ -33,10 +32,10 @@
public class JdbcBatchCreator implements BatchCreator<JdbcSubScan> {
@Override
public ScanBatch getBatch(FragmentContext context, JdbcSubScan config,
- List<RecordBatch> children) throws ExecutionSetupException {
+ List<RecordBatch> children) throws ExecutionSetupException {
Preconditions.checkArgument(children.isEmpty());
JdbcStoragePlugin plugin = config.getPlugin();
- RecordReader reader = new JdbcRecordReader(context, plugin.getSource(), config.getSql(), plugin.getName());
+ RecordReader reader = new JdbcRecordReader(plugin.getSource(), config.getSql(), plugin.getName());
--- End diff --
Now I can't find the file either. Consider this issue resolved.
---