You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/02 01:54:19 UTC

[GitHub] [iotdb] neuyilan commented on a change in pull request #2753: Extract the common codes to one utils class & Reduce the content of debug log printing of the InsertRowsPlan

neuyilan commented on a change in pull request #2753:
URL: https://github.com/apache/iotdb/pull/2753#discussion_r585189098



##########
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##########
@@ -1156,11 +1156,11 @@ public TSStatus insertRecords(TSInsertRecordsReq req) {
         TSStatus status = checkAuthority(plan, req.getSessionId());
         if (status != null) {
           insertRowsPlan.getResults().put(i, status);
-          allSuccess = false;

Review comment:
       it will not be executed, this is done in the insert(InsertRowsPlan plan)  method in PlanExecutor.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org