You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@any23.apache.org by le...@apache.org on 2013/06/09 20:55:16 UTC
git commit: change scope of slf4j dep in basic-crawler to compile
Updated Branches:
refs/heads/master ff5ad20c3 -> efc59281b
change scope of slf4j dep in basic-crawler to compile
Project: http://git-wip-us.apache.org/repos/asf/any23/repo
Commit: http://git-wip-us.apache.org/repos/asf/any23/commit/efc59281
Tree: http://git-wip-us.apache.org/repos/asf/any23/tree/efc59281
Diff: http://git-wip-us.apache.org/repos/asf/any23/diff/efc59281
Branch: refs/heads/master
Commit: efc59281bd4a6d6b46cadb805538760fa7ecb4f2
Parents: ff5ad20
Author: lewismc <le...@gmail.com>
Authored: Sun Jun 9 11:55:04 2013 -0700
Committer: lewismc <le...@gmail.com>
Committed: Sun Jun 9 11:55:04 2013 -0700
----------------------------------------------------------------------
plugins/basic-crawler/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/any23/blob/efc59281/plugins/basic-crawler/pom.xml
----------------------------------------------------------------------
diff --git a/plugins/basic-crawler/pom.xml b/plugins/basic-crawler/pom.xml
index e75cfad..28578c6 100644
--- a/plugins/basic-crawler/pom.xml
+++ b/plugins/basic-crawler/pom.xml
@@ -77,7 +77,7 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
<version>${slf4j.logger.version}</version>
- <scope>test</scope>
+ <scope>compile</scope>
</dependency>
<!-- BEGIN: plugins -->
Re: git commit: change scope of slf4j dep in basic-crawler to compile
Posted by Simone Tripodi <si...@apache.org>.
Hi mate,
why `compile`? The only required logging dependency at compile time
should be just the APIs, I'd suggest to move log4j bridge to `provide`
or `runtime`
HTH,
-Simo
http://people.apache.org/~simonetripodi/
http://twitter.com/simonetripodi
On Sun, Jun 9, 2013 at 8:55 PM, <le...@apache.org> wrote:
> Updated Branches:
> refs/heads/master ff5ad20c3 -> efc59281b
>
>
> change scope of slf4j dep in basic-crawler to compile
>
>
> Project: http://git-wip-us.apache.org/repos/asf/any23/repo
> Commit: http://git-wip-us.apache.org/repos/asf/any23/commit/efc59281
> Tree: http://git-wip-us.apache.org/repos/asf/any23/tree/efc59281
> Diff: http://git-wip-us.apache.org/repos/asf/any23/diff/efc59281
>
> Branch: refs/heads/master
> Commit: efc59281bd4a6d6b46cadb805538760fa7ecb4f2
> Parents: ff5ad20
> Author: lewismc <le...@gmail.com>
> Authored: Sun Jun 9 11:55:04 2013 -0700
> Committer: lewismc <le...@gmail.com>
> Committed: Sun Jun 9 11:55:04 2013 -0700
>
> ----------------------------------------------------------------------
> plugins/basic-crawler/pom.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/any23/blob/efc59281/plugins/basic-crawler/pom.xml
> ----------------------------------------------------------------------
> diff --git a/plugins/basic-crawler/pom.xml b/plugins/basic-crawler/pom.xml
> index e75cfad..28578c6 100644
> --- a/plugins/basic-crawler/pom.xml
> +++ b/plugins/basic-crawler/pom.xml
> @@ -77,7 +77,7 @@
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-log4j12</artifactId>
> <version>${slf4j.logger.version}</version>
> - <scope>test</scope>
> + <scope>compile</scope>
> </dependency>
>
> <!-- BEGIN: plugins -->
>