You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2023/10/26 21:07:20 UTC
[PR] [MPOM-440] Add maven-checkstyle-plugin to pluginManagement [maven-apache-parent]
slawekjaranowski opened a new pull request, #173:
URL: https://github.com/apache/maven-apache-parent/pull/173
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPOM-440] Add maven-checkstyle-plugin to pluginManagement [maven-apache-parent]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #173:
URL: https://github.com/apache/maven-apache-parent/pull/173#discussion_r1373953619
##########
pom.xml:
##########
@@ -181,6 +182,11 @@ under the License.
<artifactId>maven-clean-plugin</artifactId>
<version>${version.maven-clean-plugin}</version>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>${version.maven-checkstyle-plugin}</version>
+ </plugin>
Review Comment:
The only problem with this is that the maven-checkstyle-plugin often uses a very old version of checkstyle, so to be useful to users, they still often have to define the plugin to override the dependency, as in:
```xml
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<dependencies>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<version>10.12.2</version>
</dependency>
</dependencies>
<executions>
<execution>
<id>check-style</id>
<goals>
<goal>check</goal>
</goals>
<configuration>
<!-- execution configuration here -->
</configuration>
</execution>
</executions>
</plugin>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPOM-440] Add maven-checkstyle-plugin to pluginManagement [maven-apache-parent]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #173:
URL: https://github.com/apache/maven-apache-parent/pull/173#discussion_r1374977804
##########
pom.xml:
##########
@@ -181,6 +182,11 @@ under the License.
<artifactId>maven-clean-plugin</artifactId>
<version>${version.maven-clean-plugin}</version>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>${version.maven-checkstyle-plugin}</version>
+ </plugin>
Review Comment:
I don't want to much complicate the ASF parent pom.
So I think that managing plugin version is good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPOM-440] Add maven-checkstyle-plugin to pluginManagement [maven-apache-parent]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #173:
URL: https://github.com/apache/maven-apache-parent/pull/173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPOM-440] Add maven-checkstyle-plugin to pluginManagement [maven-apache-parent]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #173:
URL: https://github.com/apache/maven-apache-parent/pull/173#issuecomment-2771758079
Resolve #385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPOM-440] Add maven-checkstyle-plugin to pluginManagement [maven-apache-parent]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #173:
URL: https://github.com/apache/maven-apache-parent/pull/173#discussion_r1374144851
##########
pom.xml:
##########
@@ -181,6 +182,11 @@ under the License.
<artifactId>maven-clean-plugin</artifactId>
<version>${version.maven-clean-plugin}</version>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>${version.maven-checkstyle-plugin}</version>
+ </plugin>
Review Comment:
yes it is true.
But newer checkstyle required JDK 11+, so in this place we can not make such assumptions.
child project also define specific plugin configurations.
So here only plugin version is reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPOM-440] Add maven-checkstyle-plugin to pluginManagement [maven-apache-parent]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on code in PR #173:
URL: https://github.com/apache/maven-apache-parent/pull/173#discussion_r1374161812
##########
pom.xml:
##########
@@ -181,6 +182,11 @@ under the License.
<artifactId>maven-clean-plugin</artifactId>
<version>${version.maven-clean-plugin}</version>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>${version.maven-checkstyle-plugin}</version>
+ </plugin>
Review Comment:
Maybe we can define checkstyle version as additional property?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org