You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "Zouxxyy (via GitHub)" <gi...@apache.org> on 2023/08/01 07:55:02 UTC

[GitHub] [hudi] Zouxxyy commented on a diff in pull request #9332: [HUDI-6625] Lazy create metadata and viewManager in HoodieTable

Zouxxyy commented on code in PR #9332:
URL: https://github.com/apache/hudi/pull/9332#discussion_r1280242712


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/HoodieSparkTable.java:
##########
@@ -53,7 +53,7 @@ protected HoodieSparkTable(HoodieWriteConfig config, HoodieEngineContext context
   public static <T> HoodieSparkTable<T> create(HoodieWriteConfig config, HoodieEngineContext context) {
     HoodieTableMetaClient metaClient =
         HoodieTableMetaClient.builder().setConf(context.getHadoopConf().get()).setBasePath(config.getBasePath())
-            .setLoadActiveTimelineOnLoad(true).setConsistencyGuardConfig(config.getConsistencyGuardConfig())

Review Comment:
   Note, I even think we don't need this parameter `loadActiveTimelineOnLoad`,  we can always lazy get it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org