[GitHub] MaxGekk commented on a change in pull request #23460: [SPARK-26544][SQL] Escape string to keep alignment with hive

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #23460: [SPARK-26544][SQL] Escape string to keep alignment with hive
URL: https://github.com/apache/spark/pull/23460#discussion_r260194612
 
 

 ##########
 File path: sql/core/pom.xml
 ##########
 @@ -151,6 +151,10 @@
       <artifactId>mockito-core</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>${hive.group}</groupId>
+      <artifactId>hive-exec</artifactId>
+    </dependency>
 
 Review comment:
   It is hard to move it there because `hiveResultString ` is used in `SQLQueryTestSuite`: https://github.com/apache/spark/blob/2a30deb85ae4e42c5cbc936383dd5c3970f4a74f/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala#L290 . If you move it to `hive`, `sql/test` will depend on `hive` but `hive` depends on `sql` which makes `mvn`/`sbt` mad.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org