You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ac...@apache.org on 2017/04/05 20:01:28 UTC
[1/3] qpid-dispatch git commit: DISPATCH-739: Fix leak of
log_messages configuration string.
Repository: qpid-dispatch
Updated Branches:
refs/heads/master c1ec00ca1 -> c4de4b340
DISPATCH-739: Fix leak of log_messages configuration string.
Project: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/commit/c4de4b34
Tree: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/tree/c4de4b34
Diff: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/diff/c4de4b34
Branch: refs/heads/master
Commit: c4de4b340830de5c8cedb6da69dfacb07ae3c37d
Parents: 98975fb
Author: Alan Conway <ac...@redhat.com>
Authored: Wed Apr 5 15:44:07 2017 -0400
Committer: Alan Conway <ac...@redhat.com>
Committed: Wed Apr 5 15:53:56 2017 -0400
----------------------------------------------------------------------
src/connection_manager.c | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-dispatch/blob/c4de4b34/src/connection_manager.c
----------------------------------------------------------------------
diff --git a/src/connection_manager.c b/src/connection_manager.c
index a6f0765..d8a5ecc 100644
--- a/src/connection_manager.c
+++ b/src/connection_manager.c
@@ -129,6 +129,7 @@ static void qd_server_config_free(qd_server_config_t *cf)
if (cf->sasl_mechanisms) free(cf->sasl_mechanisms);
if (cf->ssl_profile) free(cf->ssl_profile);
if (cf->failover_list) qd_failover_list_free(cf->failover_list);
+ if (cf->log_message) free(cf->log_message);
memset(cf, 0, sizeof(*cf));
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org
[2/3] qpid-dispatch git commit: DISPATCH-739: Clear both
pn_link/qd_link context pointers on free
Posted by ac...@apache.org.
DISPATCH-739: Clear both pn_link/qd_link context pointers on free
Fixes 'invalid read' valgrind error in system tests.
close_links() can traverses the pn_link_t chain twice, before zeroing the pointer
the second pass was using a dangling context pointer to a freed qd_link.
Project: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/commit/98975fb6
Tree: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/tree/98975fb6
Diff: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/diff/98975fb6
Branch: refs/heads/master
Commit: 98975fb6d3ffd514f4f451dafa1b5b08c4676a60
Parents: db075fe
Author: Alan Conway <ac...@redhat.com>
Authored: Wed Apr 5 15:03:14 2017 -0400
Committer: Alan Conway <ac...@redhat.com>
Committed: Wed Apr 5 15:53:56 2017 -0400
----------------------------------------------------------------------
src/container.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-dispatch/blob/98975fb6/src/container.c
----------------------------------------------------------------------
diff --git a/src/container.c b/src/container.c
index d6d9c78..3e60ee0 100644
--- a/src/container.c
+++ b/src/container.c
@@ -827,7 +827,10 @@ qd_link_t *qd_link(qd_node_t *node, qd_connection_t *conn, qd_direction_t dir, c
void qd_link_free(qd_link_t *link)
{
if (!link) return;
- link->pn_link = 0;
+ if (link->pn_link) {
+ pn_link_set_context(link->pn_link, 0);
+ link->pn_link = 0;
+ }
link->pn_sess = 0;
free_qd_link_t(link);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org
[3/3] qpid-dispatch git commit: DISPATCH-739: Enable valgrind
leak-check=full for definite leaks only.
Posted by ac...@apache.org.
DISPATCH-739: Enable valgrind leak-check=full for definite leaks only.
Only for definite leaks, avoid deluge of "possibly lost" noise from python.
Project: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/commit/db075fee
Tree: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/tree/db075fee
Diff: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/diff/db075fee
Branch: refs/heads/master
Commit: db075feeac1294c8b2093bc564893e1d5236a43d
Parents: c1ec00c
Author: Alan Conway <ac...@redhat.com>
Authored: Tue Apr 4 14:07:47 2017 -0400
Committer: Alan Conway <ac...@redhat.com>
Committed: Wed Apr 5 15:53:56 2017 -0400
----------------------------------------------------------------------
run.py.in | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-dispatch/blob/db075fee/run.py.in
----------------------------------------------------------------------
diff --git a/run.py.in b/run.py.in
index eea8882..266a703 100755
--- a/run.py.in
+++ b/run.py.in
@@ -116,7 +116,12 @@ VALGRIND_ERROR = 42 # magic number indicating valgrind found errors
def with_valgrind(args, outfile=None):
if use_valgrind() and is_binary_exe(find_exe(args[0])):
opts = ['--trace-children=yes',
- # '--leak-check=full', way too noisy due to Python leaks
+ '--leak-check=full',
+ # Python generates a ton of "possibly lost" and "still in use"
+ # false alarms, restrict to "definite" leaks.
+ # Ideally we should have more specific python exclusions.
+ '--show-leak-kinds=definite',
+ '--errors-for-leak-kinds=definite',
'--demangle=yes',
'--num-callers=12',
'--error-exitcode=%d' % VALGRIND_ERROR,
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org