You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by jb...@apache.org on 2011/12/06 15:36:09 UTC

svn commit: r1210938 - /karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/ldap/LDAPLoginModule.java

Author: jbonofre
Date: Tue Dec  6 14:36:08 2011
New Revision: 1210938

URL: http://svn.apache.org/viewvc?rev=1210938&view=rev
Log:
[KARAF-606] Set the roleNameAttribute attribute optional in the LdapLoginModule

Modified:
    karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/ldap/LDAPLoginModule.java

Modified: karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/ldap/LDAPLoginModule.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/ldap/LDAPLoginModule.java?rev=1210938&r1=1210937&r2=1210938&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/ldap/LDAPLoginModule.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/ldap/LDAPLoginModule.java Tue Dec  6 14:36:08 2011
@@ -239,7 +239,9 @@ public class LDAPLoginModule extends Abs
             } else {
                 controls.setSearchScope(SearchControls.ONELEVEL_SCOPE);
             }
-            controls.setReturningAttributes(new String[]{ roleNameAttribute });
+            if (roleNameAttribute != null) {
+                controls.setReturningAttributes(new String[]{ roleNameAttribute });
+            }
             logger.debug("Looking for the user roles in LDAP with ");
             logger.debug("  base DN: " + roleBaseDN);
             roleFilter = roleFilter.replaceAll("%u", user);