You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by avikganguly01 <gi...@git.apache.org> on 2017/10/08 16:29:57 UTC

[GitHub] fineract pull request #410: sms notification

Github user avikganguly01 commented on a diff in the pull request:

    https://github.com/apache/fineract/pull/410#discussion_r143359309
  
    --- Diff: fineract-provider/dependencies.gradle ---
    @@ -92,7 +92,10 @@ dependencies {
                     // Once we've switched to Java 8 this dep can be removed.
                     //[group: 'com.google.code.findbugs', name: 'jsr305', version: '3.0.0']
                     [group: 'org.springframework', name:'spring-jms'],
    -                [group: 'org.apache.activemq', name: 'activemq-broker']
    +                [group: 'org.apache.activemq', name: 'activemq-broker'],
    +				
    +				//jso simple 
    +				[group: 'com.googlecode.json-simple', name: 'json-simple', version: '1.1']
    --- End diff --
    
    Please refactor usage of json-simple to GSON library. This will lead to ambiguity during imports and non-standardization of json parsing in the platform.


---