[GitHub] [airflow] potiuk edited a comment on issue #14505: Build failed likely due to unclean state of repo for self-hosted runner

[GitBox <gi...@apache.org>]

potiuk edited a comment on issue #14505:
URL: https://github.com/apache/airflow/issues/14505#issuecomment-787512598


   > Will take a look in detail tomorrow, but permissions are being reset by https://github.com/apache/airflow-ci-infra/blob/user-data-WIP/cloud-init.yml#L129.
   > 
   > Wonder what went on here
   
   Is the chown run always before ? And with root user ?
   
   I think this is one of those cases where I prefer to have a completely "pristine"  empty directory rather trying to reuse last checkout.
   
   GitHub checkout by default only fetches one single commit, it is super-fast so we save basically nothing by caching the result of previous checkout. And we avoid any kind of errors like this one - where some edge case we missed happens. 
   
   I had in the past numerous similar issues on pretty much every single CI system I built. And starting from clean state was always final state I got to.  This saved a lot of time for me and for the users trying to understand what's going on. 
   
   I propose we just hard-wipe workdir always. We will save a lot of time for debugging.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org