[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #675: Inherit snapshot ids for manifest entries

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #675: Inherit snapshot ids for manifest entries
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r364317990
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/ManifestReader.java
 ##########
 @@ -78,11 +80,27 @@ public static ManifestReader read(InputFile file) {
    * @param specsById a Map from spec ID to partition spec
    * @return a manifest reader
    */
+  // TODO: do we want to keep it?
   public static ManifestReader read(InputFile file, Map<Integer, PartitionSpec> specsById) {
 
 Review comment:
   The remaining usages are only in tests and `specsById` is always `null`. I am inclined to remove this method completely.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org