You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/12/01 10:35:41 UTC
Review Request 64244: KYLIN-3076: Make kylin remember the choices we
have made in the "Monitor>Jobs" page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64244/
-----------------------------------------------------------
Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.
Bugs: KYLIN-3076
https://issues.apache.org/jira/browse/KYLIN-3076
Repository: kylin
Description
-------
In "Monitor>Jobs" page, the defaut setting is to list all the jobs in the last one week, if we only want to see the jobs whose cube named "cube1" and was successfully finished in the last one month, we have to type "cube1" in the filter box, select "LAST ONE MONTH" in the drop-down box, and check the "FINISHED" item in the job status checkbox, then click the "refresh" button, the results we want will come out. But, when we leave this page for a moment, for example, we click "MODEL" menu to see the model infomation and then click "MONITOR" menu to turn back to the monitor page, we will find that all the choices we have made was gone, and have to do it again to filter out the jobs we want.
We hope that kylin can remember the choices we have made in the "Monitor>Jobs" page, so we don't have to make the same choices everytime when we enter this page.
Diffs
-----
webapp/app/js/controllers/job.js abb3bed22
Diff: https://reviews.apache.org/r/64244/diff/1/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 64244: KYLIN-3076: Make kylin remember the choices
we have made in the "Monitor>Jobs" page
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64244/
-----------------------------------------------------------
(Updated 十二月 14, 2017, 10:48 a.m.)
Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.
Changes
-------
fix bug that kylin also remember checkbox status when the user doesn't submit.
Bugs: KYLIN-3076
https://issues.apache.org/jira/browse/KYLIN-3076
Repository: kylin
Description
-------
In "Monitor>Jobs" page, the defaut setting is to list all the jobs in the last one week, if we only want to see the jobs whose cube named "cube1" and was successfully finished in the last one month, we have to type "cube1" in the filter box, select "LAST ONE MONTH" in the drop-down box, and check the "FINISHED" item in the job status checkbox, then click the "refresh" button, the results we want will come out. But, when we leave this page for a moment, for example, we click "MODEL" menu to see the model infomation and then click "MONITOR" menu to turn back to the monitor page, we will find that all the choices we have made was gone, and have to do it again to filter out the jobs we want.
We hope that kylin can remember the choices we have made in the "Monitor>Jobs" page, so we don't have to make the same choices everytime when we enter this page.
Diffs (updated)
-----
webapp/app/js/controllers/job.js 8e460fae0
webapp/app/js/controllers/page.js 0b5ded742
webapp/app/js/model/jobListModel.js 95e0be3bc
Diff: https://reviews.apache.org/r/64244/diff/4/
Changes: https://reviews.apache.org/r/64244/diff/3-4/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 64244: KYLIN-3076: Make kylin remember the choices
we have made in the "Monitor>Jobs" page
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64244/
-----------------------------------------------------------
(Updated 十二月 13, 2017, 2:01 a.m.)
Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.
Changes
-------
Clean the choices when user logout
Bugs: KYLIN-3076
https://issues.apache.org/jira/browse/KYLIN-3076
Repository: kylin
Description
-------
In "Monitor>Jobs" page, the defaut setting is to list all the jobs in the last one week, if we only want to see the jobs whose cube named "cube1" and was successfully finished in the last one month, we have to type "cube1" in the filter box, select "LAST ONE MONTH" in the drop-down box, and check the "FINISHED" item in the job status checkbox, then click the "refresh" button, the results we want will come out. But, when we leave this page for a moment, for example, we click "MODEL" menu to see the model infomation and then click "MONITOR" menu to turn back to the monitor page, we will find that all the choices we have made was gone, and have to do it again to filter out the jobs we want.
We hope that kylin can remember the choices we have made in the "Monitor>Jobs" page, so we don't have to make the same choices everytime when we enter this page.
Diffs (updated)
-----
webapp/app/js/controllers/job.js 8e460fae0
webapp/app/js/controllers/page.js 0b5ded742
webapp/app/js/model/jobListModel.js 95e0be3bc
Diff: https://reviews.apache.org/r/64244/diff/3/
Changes: https://reviews.apache.org/r/64244/diff/2-3/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 64244: KYLIN-3076: Make kylin remember the choices
we have made in the "Monitor>Jobs" page
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64244/
-----------------------------------------------------------
(Updated 十二月 5, 2017, 5:43 a.m.)
Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.
Changes
-------
Abandon sessionStorage and create a new object in jobListModel.js to manage it.
Bugs: KYLIN-3076
https://issues.apache.org/jira/browse/KYLIN-3076
Repository: kylin
Description
-------
In "Monitor>Jobs" page, the defaut setting is to list all the jobs in the last one week, if we only want to see the jobs whose cube named "cube1" and was successfully finished in the last one month, we have to type "cube1" in the filter box, select "LAST ONE MONTH" in the drop-down box, and check the "FINISHED" item in the job status checkbox, then click the "refresh" button, the results we want will come out. But, when we leave this page for a moment, for example, we click "MODEL" menu to see the model infomation and then click "MONITOR" menu to turn back to the monitor page, we will find that all the choices we have made was gone, and have to do it again to filter out the jobs we want.
We hope that kylin can remember the choices we have made in the "Monitor>Jobs" page, so we don't have to make the same choices everytime when we enter this page.
Diffs (updated)
-----
webapp/app/js/controllers/job.js 8e460fae0
webapp/app/js/model/jobListModel.js 95e0be3bc
Diff: https://reviews.apache.org/r/64244/diff/2/
Changes: https://reviews.apache.org/r/64244/diff/1-2/
Testing
-------
Thanks,
pengjianhua