You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/23 23:12:12 UTC

[GitHub] [incubator-pinot] agrawaldevesh commented on issue #4740: [New Transformation function] Presto compatible DateTrunc

agrawaldevesh commented on issue #4740: [New Transformation function] Presto compatible DateTrunc
URL: https://github.com/apache/incubator-pinot/pull/4740#issuecomment-545673979
 
 
   @snleee @mayankshriv can you please review this PR. 
   
   The context is that we would like presto's use of the date_trunc (using PR https://github.com/prestodb/presto/pull/13504 in the prestodb) to be translated to this new presto compatible date_trunc I am adding in pinot. This will ensure faithful translation supporting both timezones and week truncations. 
   
   Currently the Pinot dateTimeConvert function truncates to the week starting at Thursday and that is incorrect from presto's standpoint.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org