You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by sateesh-chodapuneedi <gi...@git.apache.org> on 2016/12/06 05:32:34 UTC

[GitHub] cloudstack pull request #1817: CLOUDSTACK-9654 Missing hypervisor mapping of...

GitHub user sateesh-chodapuneedi opened a pull request:

    https://github.com/apache/cloudstack/pull/1817

    CLOUDSTACK-9654 Missing hypervisor mapping of various SUSE Linux gues\u2026

    \u2026t os versions on VMware 6.0
    
    Issue: Currently many versions of SUSE Linux does not have any hypervisor mapping entry in guest_os_hypervisor table in cloud database for VMware 6.0. Also observed that the guest_os_name field is incorrect for some SUSE Linux variants, which results in deployed instance (with SUSE Linux) set to guest OS type as "Other (64-bit)" on vCenter, which would not represent the guest OS accurately on hypervisor.
    
    Fix: Add the missing hypervisor mappings
    Signed-off-by: Sateesh Chodapuneedi <sa...@accelerite.com>
    
    The current (4.9) list of SUSE Linux guest os in database looks as below,
    
    > mysql> select id,display_name from guest_os where display_name like '%suse%';
    > +-----+----------------------------------------------+
    > | id  | display_name                                 |
    > +-----+----------------------------------------------+
    > |  40 | SUSE Linux Enterprise Server 9 SP4 (32-bit)  |
    > |  41 | SUSE Linux Enterprise Server 10 SP1 (32-bit) |
    > |  42 | SUSE Linux Enterprise Server 10 SP1 (64-bit) |
    > |  43 | SUSE Linux Enterprise Server 10 SP2 (32-bit) |
    > |  44 | SUSE Linux Enterprise Server 10 SP2 (64-bit) |
    > |  45 | SUSE Linux Enterprise Server 10 SP3 (64-bit) |
    > |  46 | SUSE Linux Enterprise Server 11 (32-bit)     |
    > |  47 | SUSE Linux Enterprise Server 11 (64-bit)     |
    > |  96 | SUSE Linux Enterprise 8(32-bit)              |
    > |  97 | SUSE Linux Enterprise 8(64-bit)              |
    > | 107 | SUSE Linux Enterprise 9(32-bit)              |
    > | 108 | SUSE Linux Enterprise 9(64-bit)              |
    > | 109 | SUSE Linux Enterprise 10(32-bit)             |
    > | 110 | SUSE Linux Enterprise 10(64-bit)             |
    > | 151 | SUSE Linux Enterprise Server 10 SP3 (32-bit) |
    > | 152 | SUSE Linux Enterprise Server 10 SP4 (64-bit) |
    > | 153 | SUSE Linux Enterprise Server 10 SP4 (32-bit) |
    > | 154 | SUSE Linux Enterprise Server 11 SP1 (64-bit) |
    > | 155 | SUSE Linux Enterprise Server 11 SP1 (32-bit) |
    > | 185 | SUSE Linux Enterprise Server 11 SP2 (64-bit) |
    > | 186 | SUSE Linux Enterprise Server 11 SP2 (32-bit) |
    > | 187 | SUSE Linux Enterprise Server 11 SP3 (64-bit) |
    > | 188 | SUSE Linux Enterprise Server 11 SP3 (32-bit) |
    > | 202 | Other SUSE Linux(32-bit)                     |
    > | 203 | Other SUSE Linux(64-bit)                     |
    > | 244 | SUSE Linux Enterprise Server 12 (64-bit)     |
    > +-----+----------------------------------------------+
    > 26 rows in set (0.00 sec)
    
    The current (4.9) hypervisor mappings for SUSE Linux guest os over VMware 6.0 in database looks as below. We can observe in the below query result, which lists all hypervisor mappings for SUSE Linux guest OS over VMware 6.0, many guest os listed in above query result are missing their mappings for VMware 6.0. Hence the need to add the missing hypervisor mappings.
    
    ```
    mysql> select o.id,o.display_name, h.guest_os_name, h.hypervisor_version from guest_os as o, guest_os_hypervisor as h where o.id=h.guest_os_id and h.hypervisor_version='6.0' and h.hypervisor_type='vmware' and o.display_name like '%SUSE%';
    +-----+----------------------------------+---------------+--------------------+
    | id  | display_name                     | guest_os_name | hypervisor_version |
    +-----+----------------------------------+---------------+--------------------+
    |  96 | SUSE Linux Enterprise 8(32-bit)  | suseGuest     | 6.0                |
    |  97 | SUSE Linux Enterprise 8(64-bit)  | suse64Guest   | 6.0                |
    | 107 | SUSE Linux Enterprise 9(32-bit)  | suseGuest     | 6.0                |
    | 108 | SUSE Linux Enterprise 9(64-bit)  | suse64Guest   | 6.0                |
    | 109 | SUSE Linux Enterprise 10(32-bit) | suseGuest     | 6.0                |
    | 110 | SUSE Linux Enterprise 10(64-bit) | suse64Guest   | 6.0                |
    | 202 | Other SUSE Linux(32-bit)         | suseGuest     | 6.0                |
    | 203 | Other SUSE Linux(64-bit)         | suse64Guest   | 6.0                |
    +-----+----------------------------------+---------------+--------------------+
    8 rows in set (0.00 sec)
    
    ```


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sateesh-chodapuneedi/cloudstack pr-cloudstack-9654

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1817.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1817
    
----
commit 5606cd25d77ed8b813d0777dd6b14b3d61aa04d3
Author: Sateesh Chodapuneedi <sa...@accelerite.com>
Date:   2016-12-05T16:42:41Z

    CLOUDSTACK-9654 Missing hypervisor mapping of various SUSE Linux guest os versions on VMware 6.0
    
    Issue: Currently many versions of SUSE Linux does not have any hypervisor mapping entry in guest_os_hypervisor table in cloud database for VMware 6.0. Also observed that the guest_os_name field is incorrect for some SUSE Linux variants, which results in deployed instance (with SUSE Linux) set to guest OS type as "Other (64-bit)" on vCenter, which would not represent the guest OS accurately on hypervisor.
    
    Fix: Add the missing hypervisor mappings
    Signed-off-by: Sateesh Chodapuneedi <sa...@accelerite.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1817: CLOUDSTACK-9654 Missing hypervisor mapping of variou...

Posted by rhtyd <gi...@git.apache.org>.

Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1817
  
    LGTM. Travis failure is due to timeout on one of the jobs, @sateesh-chodapuneedi can you push -f to rekick Travis.
    
    @blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1817: CLOUDSTACK-9654 Missing hypervisor mapping of variou...

Posted by rhtyd <gi...@git.apache.org>.

Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1817
  
    Thanks @sateesh-chodapuneedi 
    @blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1817: CLOUDSTACK-9654 Missing hypervisor mapping of variou...

Posted by blueorangutan <gi...@git.apache.org>.

Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1817
  
    Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-350


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1817: CLOUDSTACK-9654 Missing hypervisor mapping of variou...

Posted by rhtyd <gi...@git.apache.org>.

Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1817
  
    @sateesh-chodapuneedi the issue is not timeout, but a failing component test in components/test_volumes. On local env, this issue is not reproducible. With Travis, this is happening intermittently but not all the time. I'll investigate this today/tomorrow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1817: CLOUDSTACK-9654 Missing hypervisor mapping of variou...

Posted by sateesh-chodapuneedi <gi...@git.apache.org>.

Github user sateesh-chodapuneedi commented on the issue:

    https://github.com/apache/cloudstack/pull/1817
  
    Changed base branch to 4.9 from master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1817: CLOUDSTACK-9654 Missing hypervisor mapping of variou...

Posted by blueorangutan <gi...@git.apache.org>.

Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1817
  
    @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1817: CLOUDSTACK-9654 Missing hypervisor mapping of variou...

Posted by rhtyd <gi...@git.apache.org>.

Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1817
  
    LGTM, this is db related change. Travis has validated this (the failure is due to one intermittent issue, recently fixed). Merging this based on manual testing against my 4.9 based db.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1817: CLOUDSTACK-9654 Missing hypervisor mapping of variou...

Posted by sateesh-chodapuneedi <gi...@git.apache.org>.

Github user sateesh-chodapuneedi commented on the issue:

    https://github.com/apache/cloudstack/pull/1817
  
    Thanks @rhtyd for merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---