You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2011/04/28 16:26:38 UTC

DO NOT REPLY [Bug 51134] New: XWPFNumbering class lacks a constructor that doesn't call onDocumentRead

https://issues.apache.org/bugzilla/show_bug.cgi?id=51134

           Summary: XWPFNumbering class lacks a constructor that doesn't
                    call onDocumentRead
           Product: POI
           Version: 3.7
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: XWPF
        AssignedTo: dev@poi.apache.org
        ReportedBy: mceuen@hp.com


When creating a new Docx document, it is impossible to add a new numbering. The
only option for creating an XWPFNumbering object is by reading in a document
that already has a Numbering section. It was suggested on the mailing list to
create an additional method on XWPFDocument that will add the numbering, and
then implement the appropriate constructor on XWPFNumbering.

Here's the original thread:
http://mail-archives.apache.org/mod_mbox/poi-user/201104.mbox/%3Calpine.DEB.2.00.1104280351400.29085@urchin.earth.li%3E

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 51134] XWPFNumbering class lacks a constructor that doesn't call onDocumentRead

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51134

--- Comment #1 from Mike McEuen <mc...@hp.com> 2011-05-20 21:40:35 UTC ---
Created attachment 27042
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27042
Changes in tar.gz format

Allow new XWPFDocuments to create Numbering and Styles elements from scratch.
Previously, these elements could only be modified if read in from existing an
existing docx. This patch also contains new methods to XWPFStyles to set
default spelling language and font properties. These changes can be moved to a
different patch/bug if necessary.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 51134] [PATCH] XWPFNumbering and XWPFStyles classes lack a constructor that doesn't call onDocumentRead

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51134

Nick Burch <ni...@alfresco.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Nick Burch <ni...@alfresco.com> 2011-07-08 13:13:11 UTC ---
Thanks, unit tests added in r1144303.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 51134] [PATCH] XWPFNumbering and XWPFStyles classes lack a constructor that doesn't call onDocumentRead

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51134

Nick Burch <ni...@alfresco.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #3 from Nick Burch <ni...@alfresco.com> 2011-05-27 13:25:55 UTC ---
Thanks, committed in r1128296.

Any chance you could knock up a quick unit test for this? A test that springs
to mind is to create a doc, add the numbering and styles and set these. Then,
save it and re-open it in XWPF, and check the expected things are all there

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 51134] [PATCH] XWPFNumbering and XWPFStyles classes lack a constructor that doesn't call onDocumentRead

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51134

Mike McEuen <mc...@hp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|XWPFNumbering class lacks a |[PATCH] XWPFNumbering and
                   |constructor that doesn't    |XWPFStyles classes lack a
                   |call onDocumentRead         |constructor that doesn't
                   |                            |call onDocumentRead

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 51134] [PATCH] XWPFNumbering and XWPFStyles classes lack a constructor that doesn't call onDocumentRead

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51134

Mike McEuen <mc...@hp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27042|1                           |0
           is patch|                            |
  Attachment #27042|text/plain                  |application/x-tar
          mime type|                            |

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 51134] [PATCH] XWPFNumbering and XWPFStyles classes lack a constructor that doesn't call onDocumentRead

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51134

Mike McEuen <mc...@hp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27043|0                           |1
           is patch|                            |

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 51134] [PATCH] XWPFNumbering and XWPFStyles classes lack a constructor that doesn't call onDocumentRead

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51134

--- Comment #4 from Mike McEuen <mc...@hp.com> 2011-07-06 20:12:31 UTC ---
Created attachment 27268
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27268
Unit tests for creating and adding Numberings and Styles to a new document.

As per Nick's suggestion, here are some unit tests for the functionality I
added.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 51134] XWPFNumbering class lacks a constructor that doesn't call onDocumentRead

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51134

--- Comment #2 from Mike McEuen <mc...@hp.com> 2011-05-20 21:40:59 UTC ---
Created attachment 27043
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27043
Diff

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org