You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gary Gregory <ga...@gmail.com> on 2015/08/21 17:57:50 UTC
[CANCEL][VOTE] Apache Commons-CSV 1.2-RC1
Canceled to fix the tag issue found by Benedikt.
Gary
On Fri, Aug 21, 2015 at 8:50 AM, Gary Gregory <ga...@gmail.com>
wrote:
> Thank you Benedikt for the review.
>
> Ah, crud, that's what I get for not doing an RC for a long time.
>
> The "extra" files are OK since, per
> https://commons.apache.org/releases/prepare.html, the tag is a copy of
> trunk.
>
> I forgot to commit pom.xml to the tag.
>
> Gary
>
> Gary
>
> On Fri, Aug 21, 2015 at 12:45 AM, Benedikt Ritter <br...@apache.org>
> wrote:
>
>> Hello Gary,
>>
>> thank you for pushing this! Here is my review.
>>
>> - Signs and hashes look good
>> - Source and binary archives have the same content
>> - Site looks good
>> - clirr and rat look good
>> - builds fine with:
>> -- Maven 3.1.1 and Java 1.6.0_65
>> -- Maven 3.3.3 and Java 1.7.0_79 and Java 1.8.0_60
>>
>> But:
>>
>> diff -rqw on the contents of the source archive and the checkout with the
>> tag gives me:
>>
>> $ diff -rqw commons-csv-1.2-src/ csv-1.2-RC1/
>> Only in csv-1.2-RC1/: .svn
>> Only in csv-1.2-RC1/: CONTRIBUTING.md
>> Only in csv-1.2-RC1/: README.md
>> Only in csv-1.2-RC1/: doap_csv.rdf
>> Files commons-csv-1.2-src/pom.xml and csv-1.2-RC1/pom.xml differ
>> Only in csv-1.2-RC1/src/test/java/org/apache/commons/csv:
>> CSVBenchmark.java
>>
>> The first four difference are okay IMHO. But the missing test in the
>> source
>> archive and the difference in the poms is a blocker for me.
>> Diffing the poms shows:
>>
>> $ diff -rw commons-csv-1.2-src/pom.xml csv-1.2-RC1/pom.xml
>> 27c27
>> < <version>1.2</version>
>> ---
>> > <version>1.2-SNAPSHOT</version>
>>
>> So the tag RC tag has the snapshot version.
>> This has to be resolved, so I have to vote -1.
>>
>> Regards,
>> Benedikt
>>
>> 2015-08-20 11:51 GMT+02:00 Gary Gregory <ga...@gmail.com>:
>>
>> > Hi All,
>> >
>> > Apache Commons-CSV 1.2-RC1 is available for review here:
>> > https://dist.apache.org/repos/dist/dev/commons/csv/
>> > (svn revision 10234)
>> >
>> > Maven artifacts are here:
>> >
>> >
>> >
>> https://repository.apache.org/content/repositories/orgapachecommons-1108/org/apache/commons/commons-csv/1.2/
>> >
>> > Details of changes since 1.1 are in the release notes:
>> >
>> https://dist.apache.org/repos/dist/dev/commons/csv/RELEASE-NOTES.txt
>> >
>> > http://people.apache.org/~ggregory/csv-1.2-RC1/site/changes-report.html
>> >
>> > I tested using:
>> >
>> > Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06;
>> > 2015-04-22T04:57:37-07:00)
>> > Maven home: C:\Java\apache-maven-3.3.3\bin\..
>> > Java version: 1.7.0_79, vendor: Oracle Corporation
>> > Java home: C:\Program Files\Java\jdk1.7.0_79\jre
>> > Default locale: en_US, platform encoding: Cp1252
>> > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>> >
>> > The tag is here:
>> >
>> > https://svn.apache.org/repos/asf/commons/proper/csv/tags/csv-1.2-RC1
>> > (svn revision 1696728)
>> >
>> > Site:
>> > http://people.apache.org/~ggregory/csv-1.2-RC1/site/
>> >
>> > The Javadocs 1.2 and archive site 1.2 links are dead until the real
>> site is
>> > publish.
>> >
>> > Clirr Report (compared to 1.1):
>> >
>> http://people.apache.org/~ggregory/csv-1.2-RC1/site/clirr-report.html
>> >
>> > RAT Report:
>> > http://people.apache.org/~ggregory/csv-1.2-RC1/site/rat-report.html
>> >
>> > KEYS:
>> > https://www.apache.org/dist/commons/KEYS
>> >
>> > Please review the release candidate and vote.
>> >
>> > This vote will close no sooner than 72 hours from August 23 2015 03:00
>> AM
>> > PST.
>> >
>> > [ ] +1 Release these artifacts
>> > [ ] +0 OK, but...
>> > [ ] -0 OK, but really should fix...
>> > [ ] -1 I oppose this release because...
>> >
>> > --
>> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> > Java Persistence with Hibernate, Second Edition
>> > <http://www.manning.com/bauer3/>
>> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> > Spring Batch in Action <http://www.manning.com/templier/>
>> > Blog: http://garygregory.wordpress.com
>> > Home: http://garygregory.com/
>> > Tweet! http://twitter.com/GaryGregory
>> >
>>
>>
>>
>> --
>> http://people.apache.org/~britter/
>> http://www.systemoutprintln.de/
>> http://twitter.com/BenediktRitter
>> http://github.com/britter
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory