You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhztheplayer (via GitHub)" <gi...@apache.org> on 2025/03/26 17:25:42 UTC
[PR] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
zhztheplayer opened a new pull request, #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145
We don't usually access child nodes in `doValidateInternal`s implementation. Such kind of validation operations should be considered cost-based optimisation and be done in whole-stage fallback or in ras or in an individual columnar rule.
The patch removes the relevant code. This could be a fix for https://github.com/apache/incubator-gluten/pull/8914's CI failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#issuecomment-2757720684
Thanks @ArnavBalyan @jinchengchenghh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#issuecomment-2755179139
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#discussion_r2016227274
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/ColumnarCollectLimitBaseExec.scala:
##########
@@ -33,15 +32,11 @@ abstract class ColumnarCollectLimitBaseExec(
override def outputPartitioning: Partitioning = SinglePartition
override protected def doValidateInternal(): ValidationResult = {
-
- if (
- (childPlan.supportsColumnar && GlutenConfig.get.enablePreferColumnar) &&
- BackendsApiManager.getSettings.supportColumnarShuffleExec() &&
- SparkShimLoader.getSparkShims.isColumnarLimitExecSupported()
- ) {
- return ValidationResult.succeeded
+ if (!SparkShimLoader.getSparkShims.isColumnarLimitExecSupported()) {
+ return ValidationResult.failed(
+ "Columnar collect-limit is unsupported under the current Spark version")
Review Comment:
It's expected if it only involves performance degradation or so. Because `doValidate()` is not expected to be called with offloaded child operators or not. If this kind of joint-optimization is required, let's consider add an individual rule with `injectPostTransform` that matches on certain patterns in the plan node tree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer merged PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#issuecomment-2755179676
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "jinchengchenghh (via GitHub)" <gi...@apache.org>.
jinchengchenghh commented on code in PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#discussion_r2016260558
##########
gluten-ut/spark32/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -364,6 +364,8 @@ class VeloxTestSettings extends BackendTestSettings {
// Need to support MAP<NullType, NullType>
.exclude(
"SPARK-27619: When spark.sql.legacy.allowHashOnMapType is true, hash can be used on Maptype")
+ .exclude("SPARK-17515: CollectLimit.execute() should perform per-partition limits")
Review Comment:
Yes, can you add the detail error message upon this exclude line, like `// Need to support MAP<NullType, NullType>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on code in PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#discussion_r2016156347
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/ColumnarCollectLimitBaseExec.scala:
##########
@@ -33,15 +32,11 @@ abstract class ColumnarCollectLimitBaseExec(
override def outputPartitioning: Partitioning = SinglePartition
override protected def doValidateInternal(): ValidationResult = {
-
- if (
- (childPlan.supportsColumnar && GlutenConfig.get.enablePreferColumnar) &&
- BackendsApiManager.getSettings.supportColumnarShuffleExec() &&
- SparkShimLoader.getSparkShims.isColumnarLimitExecSupported()
- ) {
- return ValidationResult.succeeded
+ if (!SparkShimLoader.getSparkShims.isColumnarLimitExecSupported()) {
+ return ValidationResult.failed(
+ "Columnar collect-limit is unsupported under the current Spark version")
Review Comment:
We may need the child operator to support columnar since this operator implementation relies on child columnar execution. Anything without it may invoke an R2C overhead between collect limit and child operator. Is this expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on code in PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#discussion_r2016304842
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/ColumnarCollectLimitBaseExec.scala:
##########
@@ -33,15 +32,11 @@ abstract class ColumnarCollectLimitBaseExec(
override def outputPartitioning: Partitioning = SinglePartition
override protected def doValidateInternal(): ValidationResult = {
-
- if (
- (childPlan.supportsColumnar && GlutenConfig.get.enablePreferColumnar) &&
- BackendsApiManager.getSettings.supportColumnarShuffleExec() &&
- SparkShimLoader.getSparkShims.isColumnarLimitExecSupported()
- ) {
- return ValidationResult.succeeded
+ if (!SparkShimLoader.getSparkShims.isColumnarLimitExecSupported()) {
+ return ValidationResult.failed(
+ "Columnar collect-limit is unsupported under the current Spark version")
Review Comment:
Sure thanks, will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#issuecomment-2755756229
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#discussion_r2016229150
##########
gluten-ut/spark32/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -364,6 +364,8 @@ class VeloxTestSettings extends BackendTestSettings {
// Need to support MAP<NullType, NullType>
.exclude(
"SPARK-27619: When spark.sql.legacy.allowHashOnMapType is true, hash can be used on Maptype")
+ .exclude("SPARK-17515: CollectLimit.execute() should perform per-partition limits")
Review Comment:
I believe there were some benign failures which can be solved in another time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on code in PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#discussion_r2016308509
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/ColumnarCollectLimitBaseExec.scala:
##########
@@ -33,15 +32,11 @@ abstract class ColumnarCollectLimitBaseExec(
override def outputPartitioning: Partitioning = SinglePartition
override protected def doValidateInternal(): ValidationResult = {
-
- if (
- (childPlan.supportsColumnar && GlutenConfig.get.enablePreferColumnar) &&
- BackendsApiManager.getSettings.supportColumnarShuffleExec() &&
- SparkShimLoader.getSparkShims.isColumnarLimitExecSupported()
- ) {
- return ValidationResult.succeeded
+ if (!SparkShimLoader.getSparkShims.isColumnarLimitExecSupported()) {
+ return ValidationResult.failed(
+ "Columnar collect-limit is unsupported under the current Spark version")
Review Comment:
Yes I'll take a follow up to add a rule thanks for the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "jinchengchenghh (via GitHub)" <gi...@apache.org>.
jinchengchenghh commented on code in PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#discussion_r2016193487
##########
gluten-ut/spark32/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -364,6 +364,8 @@ class VeloxTestSettings extends BackendTestSettings {
// Need to support MAP<NullType, NullType>
.exclude(
"SPARK-27619: When spark.sql.legacy.allowHashOnMapType is true, hash can be used on Maptype")
+ .exclude("SPARK-17515: CollectLimit.execute() should perform per-partition limits")
Review Comment:
Can you add the exclude reason here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#discussion_r2016227274
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/ColumnarCollectLimitBaseExec.scala:
##########
@@ -33,15 +32,11 @@ abstract class ColumnarCollectLimitBaseExec(
override def outputPartitioning: Partitioning = SinglePartition
override protected def doValidateInternal(): ValidationResult = {
-
- if (
- (childPlan.supportsColumnar && GlutenConfig.get.enablePreferColumnar) &&
- BackendsApiManager.getSettings.supportColumnarShuffleExec() &&
- SparkShimLoader.getSparkShims.isColumnarLimitExecSupported()
- ) {
- return ValidationResult.succeeded
+ if (!SparkShimLoader.getSparkShims.isColumnarLimitExecSupported()) {
+ return ValidationResult.failed(
+ "Columnar collect-limit is unsupported under the current Spark version")
Review Comment:
It's expected if it only involves performance degradation or so. Because `doValidate()` is not expected to be called with offloaded child operators or not. If this kind of joint-optimization is required, let's consider adding an individual rule with `injectPostTransform` that matches on certain patterns in the plan node tree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#issuecomment-2757685405
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#issuecomment-2757683546
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#issuecomment-2757692212
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#discussion_r2016271492
##########
gluten-ut/spark32/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -364,6 +364,8 @@ class VeloxTestSettings extends BackendTestSettings {
// Need to support MAP<NullType, NullType>
.exclude(
"SPARK-27619: When spark.sql.legacy.allowHashOnMapType is true, hash can be used on Maptype")
+ .exclude("SPARK-17515: CollectLimit.execute() should perform per-partition limits")
Review Comment:
Let's get this merged so you can proceed with https://github.com/apache/incubator-gluten/pull/8914.
One can blame the change to find this PR for failure details. The error log is [here](https://github.com/apache/incubator-gluten/actions/runs/14089831855/job/39463604913).
Just revert the test changes once implemented a new rule following https://github.com/apache/incubator-gluten/pull/9145#discussion_r2016227274.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#issuecomment-2755213837
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#discussion_r2016307364
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/ColumnarCollectLimitBaseExec.scala:
##########
@@ -33,15 +32,11 @@ abstract class ColumnarCollectLimitBaseExec(
override def outputPartitioning: Partitioning = SinglePartition
override protected def doValidateInternal(): ValidationResult = {
-
- if (
- (childPlan.supportsColumnar && GlutenConfig.get.enablePreferColumnar) &&
- BackendsApiManager.getSettings.supportColumnarShuffleExec() &&
- SparkShimLoader.getSparkShims.isColumnarLimitExecSupported()
- ) {
- return ValidationResult.succeeded
+ if (!SparkShimLoader.getSparkShims.isColumnarLimitExecSupported()) {
+ return ValidationResult.failed(
+ "Columnar collect-limit is unsupported under the current Spark version")
Review Comment:
@ArnavBalyan Will you be fine with this? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#discussion_r2016323708
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/ColumnarCollectLimitBaseExec.scala:
##########
@@ -33,15 +32,11 @@ abstract class ColumnarCollectLimitBaseExec(
override def outputPartitioning: Partitioning = SinglePartition
override protected def doValidateInternal(): ValidationResult = {
-
- if (
- (childPlan.supportsColumnar && GlutenConfig.get.enablePreferColumnar) &&
- BackendsApiManager.getSettings.supportColumnarShuffleExec() &&
- SparkShimLoader.getSparkShims.isColumnarLimitExecSupported()
- ) {
- return ValidationResult.succeeded
+ if (!SparkShimLoader.getSparkShims.isColumnarLimitExecSupported()) {
+ return ValidationResult.failed(
+ "Columnar collect-limit is unsupported under the current Spark version")
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Remove inlined children plan access during native validation of Exchange / CollectLimit [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9145:
URL: https://github.com/apache/incubator-gluten/pull/9145#issuecomment-2757688824
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org