You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/11/09 17:21:00 UTC

[GitHub] [submarine] kobe860219 opened a new pull request #449: SUBMARINE-673. ERROR : Cannot read property 'environment' of null

kobe860219 opened a new pull request #449:
URL: https://github.com/apache/submarine/pull/449


   ### What is this PR for?
   If there is no environment in submarine server, clicking the button "+ New notebook" will output error message "ERROR TypeError: Cannot read property 'environment' of null" to the web console and the modal do not open.
   
   1. Set notebook-env can't be deleted in environment page of UI.
   2. Set notebook-env as default environment when create new notebook in notebook page of UI.
   
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-673
   
   ### How should this be tested?
   https://travis-ci.org/github/kobe860219/submarine/builds/742502456
   
   ### Screenshots (if appropriate)
   ![螢幕錄製 2020-11-10 上午12](https://user-images.githubusercontent.com/48027290/98574254-a9bb8180-22f2-11eb-9b9d-421263afe564.gif)
   
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #449: SUBMARINE-673. Fixed Cannot read property 'environment' of null

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #449:
URL: https://github.com/apache/submarine/pull/449


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] kobe860219 commented on pull request #449: SUBMARINE-673. ERROR : Cannot read property 'environment' of null

Posted by GitBox <gi...@apache.org>.
kobe860219 commented on pull request #449:
URL: https://github.com/apache/submarine/pull/449#issuecomment-724155895


   @lowc1012 Please help me take a look this PR. Thanks :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org