You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/08/14 13:45:27 UTC
[GitHub] [hadoop] adoroszlai opened a new pull request #1295: HDDS-1966.
Wrong expected key ACL in acceptance test
adoroszlai opened a new pull request #1295: HDDS-1966. Wrong expected key ACL in acceptance test
URL: https://github.com/apache/hadoop/pull/1295
## What changes were proposed in this pull request?
Acceptance test [fails at ACL checks](https://elek.github.io/ozone-ci/trunk/trunk-nightly-wxhxr/acceptance/smokeresult/log.html#s1-s16-s2-t4-k2):
```
[ {
"type" : "USER",
"name" : "testuser/scm@EXAMPLE.COM",
"aclScope" : "ACCESS",
"aclList" : [ "ALL" ]
}, {
"type" : "GROUP",
"name" : "root",
"aclScope" : "ACCESS",
"aclList" : [ "ALL" ]
}, {
"type" : "GROUP",
"name" : "superuser1",
"aclScope" : "ACCESS",
"aclList" : [ "ALL" ]
}, {
"type" : "USER",
"name" : "superuser1",
"aclScope" : "ACCESS",
"aclList" : [ "READ", "WRITE", "READ_ACL", "WRITE_ACL" ]
} ]' does not match '"type" : "GROUP",
.*"name" : "superuser1*",
.*"aclScope" : "ACCESS",
.*"aclList" : . "READ", "WRITE", "READ_ACL", "WRITE_ACL"'
```
The test [sets user ACL](https://github.com/apache/hadoop/blob/0e4b757955ae8da1651b870c12458e3344c0b613/hadoop-ozone/dist/src/main/smoketest/basic/ozone-shell.robot#L123), but [checks group ACL](https://github.com/apache/hadoop/blob/0e4b757955ae8da1651b870c12458e3344c0b613/hadoop-ozone/dist/src/main/smoketest/basic/ozone-shell.robot#L125). I think this passed previously due to a bug that was [fixed](https://github.com/apache/hadoop/pull/1234/files#diff-2d061b57a9838854d07da9e0eca64f31) by [HDDS-1917](https://issues.apache.org/jira/browse/HDDS-1917).
https://issues.apache.org/jira/browse/HDDS-1966
## How was this patch tested?
Ran `ozonesecure` acceptance test, verified that key ACL checks were passing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org