[GitHub] mistercrunch commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #4890: [bugfix] temporal columns with expression fail
URL: https://github.com/apache/incubator-superset/pull/4890#discussion_r184538061
 
 

 ##########
 File path: tests/model_tests.py
 ##########
 @@ -105,3 +105,9 @@ def test_grains_dict(self):
         self.assertEquals(d.get('day').function, 'DATE({col})')
         self.assertEquals(d.get('P1D').function, 'DATE({col})')
         self.assertEquals(d.get('Time Column').function, '{col}')
+
+    def test_get_timestamp_expression(self):
+        tbl = self.get_table_by_name('birth_names')
+        ds_col = tbl.get_column('ds')
+        sqla_literal = ds_col.get_timestamp_expression(None)
 
 Review comment:
   The problem is the test will fail depending on the database it's working on. I guess I can figure out which engine it's on (postgres/mysql) and do the proper assertion depending on that

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services