[GitHub] spark pull request #14065: [SPARK-14743][YARN][WIP] Add a configurable token...

[tgravescs <gi...@git.apache.org>]

Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14065#discussion_r69916415
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/token/AMDelegationTokenRenewer.scala ---
    @@ -171,10 +174,9 @@ private[yarn] class AMDelegationTokenRenewer(
         keytabLoggedInUGI.doAs(new PrivilegedExceptionAction[Void] {
           // Get a copy of the credentials
           override def run(): Void = {
    -        val nns = YarnSparkHadoopUtil.get.getNameNodesToAccess(sparkConf) + dst
    -        hadoopUtil.obtainTokensForNamenodes(nns, freshHadoopConf, tempCreds)
    -        hadoopUtil.obtainTokenForHiveMetastore(sparkConf, freshHadoopConf, tempCreds)
    -        hadoopUtil.obtainTokenForHBase(sparkConf, freshHadoopConf, tempCreds)
    +        hdfsTokenProvider(sparkConf).setNameNodesToAccess(sparkConf, Set(dst))
    +        hdfsTokenProvider(sparkConf).setTokenRenewer(null)
    --- End diff --
    
    why are we setting this to null here?  is it supposed to indicate that its not supposed to be renewed internally?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org