You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/11/30 22:06:26 UTC
[GitHub] [trafficcontrol] ezelkow1 opened a new issue #5336: Traffic Monitor configuration via ATC parameters
ezelkow1 opened a new issue #5336:
URL: https://github.com/apache/trafficcontrol/issues/5336
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
- For *SUPPORT QUESTIONS*, use the Traffic Control slack (https://s.apache.org/atc-slack)
or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
-->
## I'm submitting a ...
<!-- delete all those that don't apply -->
<!--- security vulnerability (STOP!! - see above)-->
- improvement request (usability, performance, tech debt, etc.)
## Traffic Control components affected ...
<!-- delete all those that don't apply -->
- Traffic Monitor
## Current behavior:
<!-- Describe how the current features are insufficient. -->
Currently there is no way to modify the traffic monitor config file with ATC. You can create a whole flat file but being able to use parameters would be much more beneficial to be able to tweak various parameters like polling times and http_polling_format to be able to change the Accept header to switch between csv and json formats.
## New behavior:
<!-- Describe how the feature would improve Traffic Control -->
Being able to configure TM using parameters would be helpful in administering TM machines
## Minimal reproduction of the problem with instructions:
<!--
If you can illustrate your feature request better with an example, please
provide the *STEPS TO REPRODUCE* and include the applicable TC version.
If not, feel free to delete this section.
-->
* Create parameters for a tm config file that correspond to all the existing defaults
* Modify some and introduce new ones like http_polling_format
* ATC would create a json formatted config file that TM can use
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on issue #5336: Traffic Monitor configuration via ATC parameters
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #5336:
URL: https://github.com/apache/trafficcontrol/issues/5336#issuecomment-736091278
Currently, polling timing and health formats are determined on a per-monitored-server basis - by ATC Parameters - not at the scope of the monitor itself. I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jhg03a commented on issue #5336: Traffic Monitor configuration via ATC parameters
Posted by GitBox <gi...@apache.org>.
jhg03a commented on issue #5336:
URL: https://github.com/apache/trafficcontrol/issues/5336#issuecomment-736836546
I can buy that compromise. If it has its own set of constraints and ui elements, that's much better than unstructured magic strings via profile+parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c edited a comment on issue #5336: Traffic Monitor configuration via ATC parameters
Posted by GitBox <gi...@apache.org>.
rob05c edited a comment on issue #5336:
URL: https://github.com/apache/trafficcontrol/issues/5336#issuecomment-736832203
@jhg03a The issue is, we want to be able to change these settings dynamically, without requiring a restart/reload, and without an Ops person manually doing things on machines.
Right now, TO/TP is how we do that with downstream apps - caches, monitors, routers, etc.
I'm not opposed to moving toward a TO-agnostic system. But TO is how we do it today, and we need the ability to do it. I'm not sure there's a good way to make it possible to config on the file, and also in TO with a TP change and Snapshot, without one stomping on the other or causing pain and confusion. If there is, I'm not opposed. But I'm guessing we'll have to put some thought into it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on issue #5336: Traffic Monitor configuration via ATC parameters
Posted by GitBox <gi...@apache.org>.
rob05c commented on issue #5336:
URL: https://github.com/apache/trafficcontrol/issues/5336#issuecomment-736830638
Agree - that's why I said "TO/TP" instead of "Parameters." +1 on real columns. But Params would still be better than config IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on issue #5336: Traffic Monitor configuration via ATC parameters
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #5336:
URL: https://github.com/apache/trafficcontrol/issues/5336#issuecomment-736752702
I tend to be hesitant to add any more special nuance to unvalidated text parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on issue #5336: Traffic Monitor configuration via ATC parameters
Posted by GitBox <gi...@apache.org>.
rob05c commented on issue #5336:
URL: https://github.com/apache/trafficcontrol/issues/5336#issuecomment-736832203
@jhg03a The issue is, we want to be able to change these settings dynamically, without requiring a restart/reload, and without an Ops person manually doing something.
Right now, TO/TP is how we do that with downstream apps - caches, monitors, routers, etc.
I'm not opposed to moving toward a TO-agnostic system. But TO is how we do it today, and we need the ability to do it. I'm not sure there's a good way to make it possible to config on the file, and also in TO with a TP change and Snapshot, without one stomping on the other or causing pain and confusion. If there is, I'm not opposed. But I'm guessing we'll have to put some thought into it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on issue #5336: Traffic Monitor configuration via ATC parameters
Posted by GitBox <gi...@apache.org>.
rob05c commented on issue #5336:
URL: https://github.com/apache/trafficcontrol/issues/5336#issuecomment-736093386
They are. About half the Monitor configs are in Parameters, and about half are in the config file.
+1 on moving them all into TO, so they can be dynamically changed from TO/TP rather than requiring a static file change and reload.
Ideally the only local Monitor config would be the TO URL+user+pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jhg03a commented on issue #5336: Traffic Monitor configuration via ATC parameters
Posted by GitBox <gi...@apache.org>.
jhg03a commented on issue #5336:
URL: https://github.com/apache/trafficcontrol/issues/5336#issuecomment-736748368
I'd rather see it go the other way personally where we take more responsibility away from TO and move how application configuration is set outside the scope of the project. There are many other tools that know how to do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ezelkow1 commented on issue #5336: Traffic Monitor configuration via ATC parameters
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on issue #5336:
URL: https://github.com/apache/trafficcontrol/issues/5336#issuecomment-736108404
Yea as of now its haphazard as to what gets configured where, plus it references rascal.txt, so its not as obvious what is going on. Just having a param->traffic_monitor.conf in ATC where it spits own the known format of that file would have it follow along with other configs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org