[GitHub] [airflow] mik-laj commented on a change in pull request #5907: [AIRFLOW-5303] Return project_id for other authorization methods

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #5907: [AIRFLOW-5303] Return project_id for other authorization methods
URL: https://github.com/apache/airflow/pull/5907#discussion_r317391600
 
 

 ##########
 File path: airflow/contrib/hooks/gcp_api_base_hook.py
 ##########
 @@ -169,7 +179,11 @@ def project_id(self) -> Optional[str]:
         :return: id of the project
         :rtype: str
         """
-        return self._get_field('project')
+        overridden_project_id = self._get_field('project')
 
 Review comment:
   I wonder if this piece of code should not be transferred to the _get_credentials_and_project_id method. Then this method will never return an invalid value and it will be easier to use it.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services