You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/07/07 19:28:39 UTC
[kudu-CR] [client][tests] fixed misprints
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7377
Change subject: [client][tests] fixed misprints
......................................................................
[client][tests] fixed misprints
Fixed misprint in warning message and test comments:
READ_AT_TIMESTAMP --> READ_AT_SNAPSHOT
This changelist does not contain any functional modifications.
Change-Id: Iec985396b263e8d1c77af01c5d38ddb2b0c1140e
---
M src/kudu/client/scan_token-internal.cc
M src/kudu/integration-tests/consistency-itest.cc
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/7377/1
--
To view, visit http://gerrit.cloudera.org:8080/7377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec985396b263e8d1c77af01c5d38ddb2b0c1140e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [client][tests] fixed misprints
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [client][tests] fixed misprints
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec985396b263e8d1c77af01c5d38ddb2b0c1140e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [client][tests] fixed misprints
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [client][tests] fixed misprints
......................................................................
Patch Set 2: Verified+1
Hit the issue addressed by http://gerrit.cloudera.org:8080/7378
--
To view, visit http://gerrit.cloudera.org:8080/7377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec985396b263e8d1c77af01c5d38ddb2b0c1140e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [client][tests] fixed misprints
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [client][tests] fixed misprints
......................................................................
Patch Set 1: Verified+1
Just another instance of the issue addressed by https://gerrit.cloudera.org/#/c/7378/
--
To view, visit http://gerrit.cloudera.org:8080/7377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec985396b263e8d1c77af01c5d38ddb2b0c1140e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-HasComments: No
[kudu-CR] [client][tests] fixed misprints
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [client][tests] fixed misprints
......................................................................
[client][tests] fixed misprints
Fixed misprint in warning message and test comments:
READ_AT_TIMESTAMP --> READ_AT_SNAPSHOT
This changelist does not contain any functional modifications.
Change-Id: Iec985396b263e8d1c77af01c5d38ddb2b0c1140e
Reviewed-on: http://gerrit.cloudera.org:8080/7377
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/client/scan_token-internal.cc
M src/kudu/integration-tests/consistency-itest.cc
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec985396b263e8d1c77af01c5d38ddb2b0c1140e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] [client][tests] fixed misprints
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [client][tests] fixed misprints
......................................................................
[client][tests] fixed misprints
Fixed misprint in warning message and test comments:
READ_AT_TIMESTAMP --> READ_AT_SNAPSHOT
This changelist does not contain any functional modifications.
Change-Id: Iec985396b263e8d1c77af01c5d38ddb2b0c1140e
---
M src/kudu/client/scan_token-internal.cc
M src/kudu/integration-tests/consistency-itest.cc
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/7377/2
--
To view, visit http://gerrit.cloudera.org:8080/7377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iec985396b263e8d1c77af01c5d38ddb2b0c1140e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>