You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/06 10:24:56 UTC
[GitHub] [flink] leonardBang opened a new pull request #10774:
[FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
leonardBang opened a new pull request #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774
[FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*This pull request reopens tests that close by FLINK-12088 、FLINK-13740、CALCITE-1860 which have been resolved.*
## Brief change log
- *update file org/apache/flink/table/planner/runtime/stream/sql/AggregateITCase.scala*
- *update file org/apache/flink/table/planner/runtime/stream/table/GroupWindowTableAggregateITCase.scala*
- *org/apache/flink/table/planner/runtime/stream/table/TableAggregateITCase.scala*
- *update file org/apache/flink/table/plan/ExpressionReductionRulesTest.scala*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): ( no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10774:
[FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#discussion_r364577311
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/JoinITCase.scala
##########
@@ -94,28 +89,19 @@ class JoinITCase(expectedJoinType: JoinType) extends BatchTestBase {
))
}
- @Ignore // TODO support lazy from source
@Test
def testLongHashJoinGenerator(): Unit = {
if (expectedJoinType == HashJoin) {
- val sink = (new CollectRowTableSink).configure(Array("c"), Array(Types.STRING))
- tEnv.registerTableSink("collect", sink)
- tEnv.insertInto("collect", tEnv.sqlQuery("SELECT c FROM SmallTable3, Table5 WHERE b = e"))
- var haveTwoOp = false
- env.getStreamGraph.getAllOperatorFactory.foreach(o =>
Review comment:
This test is for testing long hash join, just a it case can not verify it.
I am OK to move it to plan test if it is work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10774:
[FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-571093161
<!--
Meta data
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143225340 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
Hash:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143391999 TriggerType:PUSH TriggerID:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f
Hash:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4163 TriggerType:PUSH TriggerID:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f
Hash:96cf9418f0e54f07af4ae05cefc95b2c2924f9af Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4213 TriggerType:PUSH TriggerID:96cf9418f0e54f07af4ae05cefc95b2c2924f9af
Hash:96cf9418f0e54f07af4ae05cefc95b2c2924f9af Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143708917 TriggerType:PUSH TriggerID:96cf9418f0e54f07af4ae05cefc95b2c2924f9af
-->
## CI report:
* bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143225340) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122)
* ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143391999) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4163)
* 96cf9418f0e54f07af4ae05cefc95b2c2924f9af Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143708917) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4213)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] leonardBang commented on a change in pull request #10774:
[FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#discussion_r364575892
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/JoinITCase.scala
##########
@@ -94,28 +89,19 @@ class JoinITCase(expectedJoinType: JoinType) extends BatchTestBase {
))
}
- @Ignore // TODO support lazy from source
@Test
def testLongHashJoinGenerator(): Unit = {
if (expectedJoinType == HashJoin) {
- val sink = (new CollectRowTableSink).configure(Array("c"), Array(Types.STRING))
- tEnv.registerTableSink("collect", sink)
- tEnv.insertInto("collect", tEnv.sqlQuery("SELECT c FROM SmallTable3, Table5 WHERE b = e"))
- var haveTwoOp = false
- env.getStreamGraph.getAllOperatorFactory.foreach(o =>
Review comment:
This is an ITcase, so I modify and compare the final result.
what's meaning of `this...`? ,I'm a little confused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] leonardBang commented on issue #10774: [FLINK-15485][tests]
Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
leonardBang commented on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-571156813
@JingsongLi `DecimalTypeTest.testDefaultDecimalCasting` can not run because of：
java.lang.ClassCastException: org.apache.flink.table.types.logical.LegacyTypeInformationType cannot be cast to org.apache.flink.table.types.logical.DecimalType
this should not contain this issue. maybe we should create an issue to fix it?
For other `ignore` tests， I'll add them ASAIK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] leonardBang edited a comment on issue #10774:
[FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
leonardBang edited a comment on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-571156813
@JingsongLi `DecimalTypeTest.testDefaultDecimalCasting` can not run because of：
java.lang.ClassCastException: org.apache.flink.table.types.logical.LegacyTypeInformationType cannot be cast to org.apache.flink.table.types.logical.DecimalType
we should not add it in this issue. Maybe we should create an issue to fix it?
For other `ignore` tests， I'll add them ASAIK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10774: [FLINK-15485][tests]
Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-571384697
I think we can check them as much as possible.
Feel free to open a jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10774:
[FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#discussion_r364551373
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/JoinITCase.scala
##########
@@ -94,28 +89,19 @@ class JoinITCase(expectedJoinType: JoinType) extends BatchTestBase {
))
}
- @Ignore // TODO support lazy from source
@Test
def testLongHashJoinGenerator(): Unit = {
if (expectedJoinType == HashJoin) {
- val sink = (new CollectRowTableSink).configure(Array("c"), Array(Types.STRING))
- tEnv.registerTableSink("collect", sink)
- tEnv.insertInto("collect", tEnv.sqlQuery("SELECT c FROM SmallTable3, Table5 WHERE b = e"))
- var haveTwoOp = false
- env.getStreamGraph.getAllOperatorFactory.foreach(o =>
Review comment:
This test is just for this...
We can just invoke `TableEnvironment.explain` to check "LongHashJoin".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10774:
[FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-571093161
<!--
Meta data
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143225340 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
Hash:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143391999 TriggerType:PUSH TriggerID:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f
Hash:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4163 TriggerType:PUSH TriggerID:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f
Hash:96cf9418f0e54f07af4ae05cefc95b2c2924f9af Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4213 TriggerType:PUSH TriggerID:96cf9418f0e54f07af4ae05cefc95b2c2924f9af
Hash:96cf9418f0e54f07af4ae05cefc95b2c2924f9af Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143708917 TriggerType:PUSH TriggerID:96cf9418f0e54f07af4ae05cefc95b2c2924f9af
-->
## CI report:
* bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143225340) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122)
* ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143391999) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4163)
* 96cf9418f0e54f07af4ae05cefc95b2c2924f9af Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143708917) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4213)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10774:
[FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-571093161
<!--
Meta data
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143225340 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
Hash:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143391999 TriggerType:PUSH TriggerID:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f
Hash:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4163 TriggerType:PUSH TriggerID:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f
-->
## CI report:
* bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143225340) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122)
* ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143391999) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4163)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10774: [FLINK-15485][tests]
Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-571093161
<!--
Meta data
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
-->
## CI report:
* bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10774:
[FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-571093161
<!--
Meta data
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143225340 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
-->
## CI report:
* bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143225340) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] leonardBang commented on issue #10774: [FLINK-15485][tests]
Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
leonardBang commented on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-572493579
> val transforms = testingTEnv.getPlanner.asInstanceOf[PlannerBase]
> .translate(testingTEnv.getBufferedOperations)
nice suggestion!
I got the importance after look up LongHashJoinOperator, but I think the test code is a little ugly although I have not better choice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] leonardBang commented on a change in pull request #10774:
[FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#discussion_r364575892
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/JoinITCase.scala
##########
@@ -94,28 +89,19 @@ class JoinITCase(expectedJoinType: JoinType) extends BatchTestBase {
))
}
- @Ignore // TODO support lazy from source
@Test
def testLongHashJoinGenerator(): Unit = {
if (expectedJoinType == HashJoin) {
- val sink = (new CollectRowTableSink).configure(Array("c"), Array(Types.STRING))
- tEnv.registerTableSink("collect", sink)
- tEnv.insertInto("collect", tEnv.sqlQuery("SELECT c FROM SmallTable3, Table5 WHERE b = e"))
- var haveTwoOp = false
- env.getStreamGraph.getAllOperatorFactory.foreach(o =>
Review comment:
This is a ITcase, so I modify and compare the final result.
what's meaning of `this...`? ,I'm a little confused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] leonardBang commented on issue #10774: [FLINK-15485][tests]
Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
leonardBang commented on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-572373098
@JingsongLi Could you have a more look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10774:
[FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-571093161
<!--
Meta data
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143225340 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
-->
## CI report:
* bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143225340) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10774:
[FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-571093161
<!--
Meta data
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143225340 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
Hash:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f
-->
## CI report:
* bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143225340) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122)
* ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10774:
[FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-571093161
<!--
Meta data
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143225340 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
Hash:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143391999 TriggerType:PUSH TriggerID:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f
Hash:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4163 TriggerType:PUSH TriggerID:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f
Hash:96cf9418f0e54f07af4ae05cefc95b2c2924f9af Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4213 TriggerType:PUSH TriggerID:96cf9418f0e54f07af4ae05cefc95b2c2924f9af
Hash:96cf9418f0e54f07af4ae05cefc95b2c2924f9af Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143708917 TriggerType:PUSH TriggerID:96cf9418f0e54f07af4ae05cefc95b2c2924f9af
-->
## CI report:
* bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143225340) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122)
* ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143391999) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4163)
* 96cf9418f0e54f07af4ae05cefc95b2c2924f9af Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143708917) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4213)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] leonardBang commented on issue #10774: [FLINK-15485][tests]
Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
leonardBang commented on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-571106772
> Thanks @leonardBang , but still a lot of ignore cases. Like `DecimalTypeTest.testDefaultDecimalCasting`, can you verify them too?
Okay, I'll add it，But there are too many ignore cases to list them once, Do you have any suggestion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10774: [FLINK-15485][tests]
Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-571086714
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd (Mon Jan 06 10:27:07 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15485).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10774: [FLINK-15485][tests]
Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-572489477
Hi @leonardBang , about long join testing, you can modify to:
```
@Test
def testLongHashJoinGenerator(): Unit = {
if (expectedJoinType == HashJoin) {
val sink = (new CollectRowTableSink).configure(Array("c"), Array(Types.STRING))
tEnv.registerTableSink("outputTable", sink)
tEnv.insertInto("outputTable", tEnv.sqlQuery("SELECT c FROM SmallTable3, Table5 WHERE b = e"))
val testingTEnv = tEnv.asInstanceOf[TestingTableEnvironment]
val transforms = testingTEnv.getPlanner.asInstanceOf[PlannerBase]
.translate(testingTEnv.getBufferedOperations)
var haveTwoOp = false
@scala.annotation.tailrec
def findTwoInputTransform(t: Transformation[_]): TwoInputTransformation[_, _, _] = {
t match {
case sink: SinkTransformation[_] => findTwoInputTransform(sink.getInput)
case one: OneInputTransformation[_, _] => findTwoInputTransform(one.getInput)
case two: TwoInputTransformation[_, _, _] => two
}
}
transforms.map(findTwoInputTransform).foreach { transform =>
transform.getOperatorFactory match {
case factory: CodeGenOperatorFactory[_] =>
if (factory.getGeneratedClass.getCode.contains("LongHashJoinOperator")) {
haveTwoOp = true
}
case _ =>
}
}
Assert.assertTrue(haveTwoOp)
}
}
```
It's important, has triggered performance regression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10774:
[FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-571093161
<!--
Meta data
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143225340 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
Hash:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143391999 TriggerType:PUSH TriggerID:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f
Hash:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4163 TriggerType:PUSH TriggerID:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f
Hash:96cf9418f0e54f07af4ae05cefc95b2c2924f9af Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:96cf9418f0e54f07af4ae05cefc95b2c2924f9af
-->
## CI report:
* bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143225340) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122)
* ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143391999) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4163)
* 96cf9418f0e54f07af4ae05cefc95b2c2924f9af UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong closed pull request #10774: [FLINK-15485][tests]
Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10774:
[FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#issuecomment-571093161
<!--
Meta data
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
Hash:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143225340 TriggerType:PUSH TriggerID:bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd
Hash:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143391999 TriggerType:PUSH TriggerID:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f
Hash:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4163 TriggerType:PUSH TriggerID:ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f
-->
## CI report:
* bf30d45bc7c1faa05786f6c7b2aca46a49cbf1dd Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143225340) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4122)
* ac50b4b78dab8fb3a743eea2025c31ea7fd66c3f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143391999) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4163)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services