You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nlpcraft.apache.org by "Sergey Kamov (Jira)" <ji...@apache.org> on 2020/07/21 13:45:00 UTC

[jira] [Resolved] (NLPCRAFT-90) NCUtils `read` methods. Ressources should be closed.

     [ https://issues.apache.org/jira/browse/NLPCRAFT-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergey Kamov resolved NLPCRAFT-90.
----------------------------------
      Assignee: Aaron Radzinski  (was: Sergey Kamov)
    Resolution: Fixed

I just change results from Stream to List (List isn't lazy collection)

If we need streams (performance issues etc) - we can add such methods later

NLPCRAFT-90

> NCUtils `read` methods. Ressources should be closed.
> ----------------------------------------------------
>
>                 Key: NLPCRAFT-90
>                 URL: https://issues.apache.org/jira/browse/NLPCRAFT-90
>             Project: NLPCraft
>          Issue Type: Improvement
>          Components: probe, server
>            Reporter: Sergey Kamov
>            Assignee: Aaron Radzinski
>            Priority: Critical
>             Fix For: 0.7.0
>
>
> NCUtils `read` methods resources should be closed (But if we close them in finally block, returned stream results is broken)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)