You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "vldpyatkov (via GitHub)" <gi...@apache.org> on 2024/02/01 13:18:34 UTC
[PR] IGNITE-21394 TimeoutException in the listener of pending assignments change shouldn't fail the watch processor [ignite-3]
vldpyatkov opened a new pull request, #3139:
URL: https://github.com/apache/ignite-3/pull/3139
https://issues.apache.org/jira/browse/IGNITE-21394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21394 TimeoutException in the listener of pending assignments change shouldn't fail the watch processor [ignite-3]
Posted by "denis-chudov (via GitHub)" <gi...@apache.org>.
denis-chudov commented on code in PR #3139:
URL: https://github.com/apache/ignite-3/pull/3139#discussion_r1474700725
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1830,8 +1832,17 @@ private CompletableFuture<Void> changePeersOnRebalance(
RaftGroupService partGrpSvc = table.internalTable().partitionRaftGroupService(partId);
return partGrpSvc.refreshAndGetLeaderWithTerm()
+ .exceptionally(throwable -> {
+ if (throwable instanceof TimeoutException) {
+ LOG.info("Node couldn't get the leader within timeout so change peer is skipped [grp={}].", replicaGrpId);
Review Comment:
```suggestion
LOG.info("Node couldn't get the leader within timeout so the changing peers is skipped [grp={}].", replicaGrpId);
```
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1830,8 +1832,17 @@ private CompletableFuture<Void> changePeersOnRebalance(
RaftGroupService partGrpSvc = table.internalTable().partitionRaftGroupService(partId);
return partGrpSvc.refreshAndGetLeaderWithTerm()
+ .exceptionally(throwable -> {
+ if (throwable instanceof TimeoutException) {
+ LOG.info("Node couldn't get the leader within timeout so change peer is skipped [grp={}].", replicaGrpId);
+
+ return LeaderWithTerm.NO_LEADER;
+ }
+
+ throw new IgniteInternalException(throwable);
Review Comment:
its deprecated, why just not rethrow? it would make sense if you added some message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21394 TimeoutException in the listener of pending assignments change shouldn't fail the watch processor [ignite-3]
Posted by "vldpyatkov (via GitHub)" <gi...@apache.org>.
vldpyatkov merged PR #3139:
URL: https://github.com/apache/ignite-3/pull/3139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org