You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jason Rutherglen (JIRA)" <ji...@apache.org> on 2011/06/05 00:44:47 UTC
[jira] [Created] (HBASE-3954) Pluggable block index
Pluggable block index
---------------------
Key: HBASE-3954
URL: https://issues.apache.org/jira/browse/HBASE-3954
Project: HBase
Issue Type: Improvement
Reporter: Jason Rutherglen
Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051171#comment-13051171 ]
Jason Rutherglen commented on HBASE-3954:
-----------------------------------------
@Stack Right, today the first key of each block is binary searched on to find the block containing the key. People may specify smaller blocks in order to [possibly] cut down on the seek time. With this issue we will decouple key search from the "first key of the block" index/array.
Users may specify larger block sizes (which will load fewer full length keys into RAM). The FST will contain more keys than the number of blocks, so the FST value will point to within the block (rather than just the beginning of the block).
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048876#comment-13048876 ]
Todd Lipcon commented on HBASE-3954:
------------------------------------
mind posting this to reviewboard since it's fairly lengthy?
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048885#comment-13048885 ]
stack commented on HBASE-3954:
------------------------------
reviews.apache.org
Make yourself an account. You post patches up there. Its a tool that makes it easier on reviewers. Yeah, should add it to the wiki page. Mind adding it Jason (after you've figured out what it is -- smile). Notion is that if patches get a little large, its best to put them up on reviews.apache.org rather than attach them to the issue. Once reviews are done, practise has been to attach the final version to the issue (though this latter is probably not necessary).
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048894#comment-13048894 ]
Jason Rutherglen commented on HBASE-3954:
-----------------------------------------
What's the "Base Directory"?
Keep getting:
"The file 'trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java' (r1135334) could not be found in the repository"
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3954) Pluggable block index
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Rutherglen updated HBASE-3954:
------------------------------------
Attachment: HBASE-3954.patch
Oops, my patch generation skills are rusty. Here it is with the missing files.
@Stack Thanks for reviewing, I'll post a new patch shortly incorporating the comments
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3954) Pluggable block index
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Rutherglen updated HBASE-3954:
------------------------------------
Attachment: HBASE-3954.patch
Here's a patch incorporating the comments given.
I am going to create an FST version next to insure the available AbstractBlockIndex method calls will work.
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048824#comment-13048824 ]
stack commented on HBASE-3954:
------------------------------
Looks good J.
You add imports in HFileOutputFormat.java but doesn't seem like you use them?
Why this is public?
{code}
+ public String blockIndexClassName = "org.apache.hadoop.hbase.io.hfile.SimpleBlockIndex";
{code}
Why not use the define you made above?
Should we let this out of HFile?
{code}
getBlockIndexImpl
{code}
Its public. Should it be private?
This seems dodgy doing it writing out the trailer:
{code}
+ try {
+ blockIndex = (AbstractBlockIndex)Class.forName(blockIndexClass).newInstance();
+ } catch (Exception ex) {
+ throw new IOException("", ex);
+ }
{code}
We've just written a bunch of data. If we fail the above for whatever reason, we get an exception and will likely lose the data we just wrote. Can this reflection be done creating the Writer and kept around for writing the trailer? If fails on construction, at least no data will have been written.
Whats going on here?
{code}
- this.metaIndex = BlockIndex.readIndex(Bytes.BYTES_RAWCOMPARATOR, dis,
+ assert metaIndex == null;
+ this.metaIndex = new SimpleBlockIndex().readIndex(Bytes.BYTES_RAWCOMPARATOR, dis,
this.trailer.metaIndexCount);
{code}
Why are we referring to SimpleBlockIndex by name?
There are files missing from your patch? SimpleBlockIndex and the Interface to implement.
Good stuff Jason.
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049484#comment-13049484 ]
jiraposter@reviews.apache.org commented on HBASE-3954:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/897/
-----------------------------------------------------------
(Updated 2011-06-14 22:29:39.103693)
Review request for hbase.
Summary
-------
HBASE-3954 patch - Make a pluggable block index system. The default implementation will be the current one.
This addresses bug HBASE-3954.
https://issues.apache.org/jira/browse/HBASE-3954
Diffs
-----
./src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractBlockIndex.java PRE-CREATION
./src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 1135334
./src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockIndex.java PRE-CREATION
./src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java 1135334
Diff: https://reviews.apache.org/r/897/diff
Testing
-------
Thanks,
jasonrutherglen
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048901#comment-13048901 ]
stack commented on HBASE-3954:
------------------------------
You a git head or svn'er? Make sure you pick appropriately -- hbase for svn and hbase-git for git. Base dir is '.' or 'trunk' (I think)
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3954) Pluggable block index
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Rutherglen updated HBASE-3954:
------------------------------------
Attachment: HBASE-3954.patch
Here's a first cut of this.
TestHFile passes (except the heap estimator), and TestMultipleTimestamps hangs(?).
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3954) Pluggable block index
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Rutherglen updated HBASE-3954:
------------------------------------
Attachment: HBASE-3954.patch
Patch with missing files.
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050799#comment-13050799 ]
Jason Rutherglen commented on HBASE-3954:
-----------------------------------------
I think the issue with this patch is I'm not yet sure how the FST (or similar prefix compression systems) will plugin. It's more a first hack at moving the code around.
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049485#comment-13049485 ]
Jason Rutherglen commented on HBASE-3954:
-----------------------------------------
In any case, here's the link to the review: https://reviews.apache.org/r/897/
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "Nicolas Spiegelberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049368#comment-13049368 ]
Nicolas Spiegelberg commented on HBASE-3954:
--------------------------------------------
@stack: Mikhail is working on the open source port. It will be about 6 sizable diffs. He should be starting that task this week.
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049483#comment-13049483 ]
Jason Rutherglen commented on HBASE-3954:
-----------------------------------------
bq. If you mention 'hbase-3954' in the 'bugs' field and/or summary, one of them triggers the review board appending JIRA.
It's in the summary and the bugs, hmm... What should happen next?
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3954) Pluggable block index
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Rutherglen updated HBASE-3954:
------------------------------------
Attachment: (was: HBASE-3954.patch)
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048908#comment-13048908 ]
Jason Rutherglen commented on HBASE-3954:
-----------------------------------------
This one's svn. I added the review, the answer to the path question is '.' Is there a link I should post here to the reviewboard?
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049590#comment-13049590 ]
jiraposter@reviews.apache.org commented on HBASE-3954:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/897/#review840
-----------------------------------------------------------
./src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractBlockIndex.java
<https://reviews.apache.org/r/897/#comment1824>
This method is covered by getBlockKey().
- Ted
On 2011-06-14 22:29:39, jasonrutherglen wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/897/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-14 22:29:39)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HBASE-3954 patch - Make a pluggable block index system. The default implementation will be the current one.
bq.
bq.
bq. This addresses bug HBASE-3954.
bq. https://issues.apache.org/jira/browse/HBASE-3954
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ./src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractBlockIndex.java PRE-CREATION
bq. ./src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 1135334
bq. ./src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockIndex.java PRE-CREATION
bq. ./src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java 1135334
bq.
bq. Diff: https://reviews.apache.org/r/897/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. jasonrutherglen
bq.
bq.
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062263#comment-13062263 ]
Jason Rutherglen commented on HBASE-3954:
-----------------------------------------
I'm not actively working on this as I think it requires seeking to within a block. I think that will be tricky.
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048880#comment-13048880 ]
Jason Rutherglen commented on HBASE-3954:
-----------------------------------------
What's reviewboard? We should add it to this page? http://wiki.apache.org/hadoop/Hbase/HowToContribute
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049342#comment-13049342 ]
stack commented on HBASE-3954:
------------------------------
@Jason If you mention 'hbase-3954' in the 'bugs' field and/or summary, one of them triggers the review board appending JIRA.
@Nicolas Any chance of the 'girls' pasting an update on the issue?
Good stuff.
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050833#comment-13050833 ]
Ted Yu commented on HBASE-3954:
-------------------------------
A draft implementation of using FST would make AbstractBlockIndex more concrete.
@Mikhail, @Liyin:
Please comment on how AbstractBlockIndex may be shaped to support multi-level indexing.
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3954) Pluggable block index
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050867#comment-13050867 ]
stack commented on HBASE-3954:
------------------------------
Yeah, an API that worked for FST and current index would give you some hope your abstraction is heading in right direction
> Pluggable block index
> ---------------------
>
> Key: HBASE-3954
> URL: https://issues.apache.org/jira/browse/HBASE-3954
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Attachments: HBASE-3954.patch, HBASE-3954.patch, HBASE-3954.patch
>
>
> Make a pluggable block index system. The default implementation will be the current one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira