You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/30 09:57:35 UTC
[GitHub] [pulsar] AnonHxy opened a new issue, #15836: Message has no redelivery count if subscription type is Exclusive or Failover
AnonHxy opened a new issue, #15836:
URL: https://github.com/apache/pulsar/issues/15836
**Describe the bug**
`Message.getRedeliveryCount()` is always zero if subscription type is Exclusive or Failove. So we can not take advantage of the `RedeliveryBackoff` which use `redeliveryCount` as a parameter.
I wander if it's a bug or feature. In other word, why only share or key_share subscription type enable subscription message redelivery tracker to send redelivery, as Line:84:
https://github.com/apache/pulsar/blob/b13d15c4d6d795f33c6ed23f920fabbb3eeaf745/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java#L72-L85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on issue #15836: Message has no redelivery count if subscription type is Exclusive or Failover
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on issue #15836:
URL: https://github.com/apache/pulsar/issues/15836#issuecomment-1142169570
@AnonHxy Failover and exclusive sub type need keeping message order, We cannot implement features which would break the message order to these sub type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on issue #15836: Message has no redelivery count if subscription type is Exclusive or Failover
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on issue #15836:
URL: https://github.com/apache/pulsar/issues/15836#issuecomment-1142177119
However failover and exclusive sub type can also invoke `negativeAcknowledge` method, which will break the message order. @gaozhangmin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nahguam commented on issue #15836: Message has no redelivery count if subscription type is Exclusive or Failover
Posted by GitBox <gi...@apache.org>.
nahguam commented on issue #15836:
URL: https://github.com/apache/pulsar/issues/15836#issuecomment-1181889407
Hi @gaozhangmin, I understand why we wouldn't want to implement features that break message ordering. However in this case, in all 4 subscription types, we can negative-ack and have the message redelivered out of order. It seems only the redelivery counter is erroneous on two of them. Can you explain how making the counter report the correct number would break message ordering?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #15836: Message has no redelivery count if subscription type is Exclusive or Failover
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #15836:
URL: https://github.com/apache/pulsar/issues/15836#issuecomment-1171851640
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on issue #15836: Message has no redelivery count if subscription type is Exclusive or Failover
Posted by GitBox <gi...@apache.org>.
coderzc commented on issue #15836:
URL: https://github.com/apache/pulsar/issues/15836#issuecomment-1141071573
It seems to be compatible with the `cumulative-ack`：https://github.com/apache/pulsar/pull/2508#discussion_r217257441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #15836: Message has no redelivery count if subscription type is Exclusive or Failover
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #15836:
URL: https://github.com/apache/pulsar/issues/15836#issuecomment-1213633777
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org