[GitHub] wdhorton opened a new pull request #3716: [AIRFLOW-XXX] Remove smart quote from default config

[GitBox <gi...@apache.org>]

wdhorton opened a new pull request #3716: [AIRFLOW-XXX] Remove smart quote from default config
URL: https://github.com/apache/incubator-airflow/pull/3716
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   I removed a [smart quotation mark](https://www.fileformat.info/info/unicode/char/2019/index.htm) from the default config, as it could cause problems with tooling because of unicode issues, and there's no real need for it. In my case, I was trying to use Fabric and cuisine to copy a config to a remote machine and it crashed with this error:
   ```
     File "/Users/william.horton/development/urbancompass/build-support/python/venvs/shorts/lib/python2.7/site-packages/cuisine.py", line 545, in file_write
       sig            = hashlib.md5(content).hexdigest()
   UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 20037: ordinal not in range(128)
   ```
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Just changing a quotation mark in a comment in the default config
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [ ] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services