You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by zh...@apache.org on 2017/08/04 23:46:47 UTC
[bookkeeper] branch master updated: ISSUE #391: CI failed with
java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing
This is an automated email from the ASF dual-hosted git repository.
zhaijia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 02580c0 ISSUE #391: CI failed with java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing
02580c0 is described below
commit 02580c0c2b2d998e1cdfdffe75458d3b7e85d1fc
Author: Sijie Guo <si...@apache.org>
AuthorDate: Sat Aug 5 07:46:34 2017 +0800
ISSUE #391: CI failed with java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing
Descriptions of the changes in this PR:
- include hamcrest dependency for tests (according to [junit](https://github.com/junit-team/junit4/wiki/Download-and-Install) instruction)
- exclude `.repository` to turn ci builds to run with its own local repository
- dump the rat check output to console (easier for debugging on jenkins)
Author: Sijie Guo <si...@apache.org>
Reviewers: Jia Zhai <None>, Matteo Merli <None>
This closes #392 from sijie/bookkeeper-test, closes #391
---
bookkeeper-benchmark/pom.xml | 6 ------
bookkeeper-server/pom.xml | 6 ------
.../codahale-metrics-provider/pom.xml | 7 -------
bookkeeper-stats/pom.xml | 6 ------
pom.xml | 23 ++++++++++++++++++++++
5 files changed, 23 insertions(+), 25 deletions(-)
diff --git a/bookkeeper-benchmark/pom.xml b/bookkeeper-benchmark/pom.xml
index daacd08..479d635 100644
--- a/bookkeeper-benchmark/pom.xml
+++ b/bookkeeper-benchmark/pom.xml
@@ -85,12 +85,6 @@
</build>
<dependencies>
<dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.8.1</version>
- <scope>test</scope>
- </dependency>
- <dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>${slf4j.version}</version>
diff --git a/bookkeeper-server/pom.xml b/bookkeeper-server/pom.xml
index 4e477e1..2df8aef 100644
--- a/bookkeeper-server/pom.xml
+++ b/bookkeeper-server/pom.xml
@@ -47,12 +47,6 @@
<version>${guava.version}</version>
</dependency>
<dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.12</version>
- <scope>test</scope>
- </dependency>
- <dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>${slf4j.version}</version>
diff --git a/bookkeeper-stats-providers/codahale-metrics-provider/pom.xml b/bookkeeper-stats-providers/codahale-metrics-provider/pom.xml
index ab620b0..2afb7c3 100644
--- a/bookkeeper-stats-providers/codahale-metrics-provider/pom.xml
+++ b/bookkeeper-stats-providers/codahale-metrics-provider/pom.xml
@@ -75,7 +75,6 @@
<artifactId>bookkeeper-stats-api</artifactId>
<version>${project.parent.version}</version>
</dependency>
-
<!-- https://mvnrepository.com/artifact/io.dropwizard.metrics/metrics-core -->
<dependency>
<groupId>io.dropwizard.metrics</groupId>
@@ -99,11 +98,5 @@
<artifactId>guava</artifactId>
<version>${guava.version}</version>
</dependency>
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.8.1</version>
- <scope>test</scope>
- </dependency>
</dependencies>
</project>
diff --git a/bookkeeper-stats/pom.xml b/bookkeeper-stats/pom.xml
index 4534834..c6a8c17 100644
--- a/bookkeeper-stats/pom.xml
+++ b/bookkeeper-stats/pom.xml
@@ -99,12 +99,6 @@
<version>1.6</version>
</dependency>
<dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.8.1</version>
- <scope>test</scope>
- </dependency>
- <dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>${slf4j.version}</version>
diff --git a/pom.xml b/pom.xml
index 9ea05b8..ee2f370 100644
--- a/pom.xml
+++ b/pom.xml
@@ -95,7 +95,10 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+ <!-- dependencies -->
<guava.version>20.0</guava.version>
+ <hamcrest.version>1.3</hamcrest.version>
+ <junit.version>4.12</junit.version>
<protobuf.version>2.6.1</protobuf.version>
<netty.version>4.1.12.Final</netty.version>
<netty-boringssl.version>2.0.3.Final</netty-boringssl.version>
@@ -108,6 +111,24 @@
<maven-javadoc-plugin.version>2.10.4</maven-javadoc-plugin.version>
<maven-source-plugin.version>2.2.1</maven-source-plugin.version>
</properties>
+
+ <!-- dependencies for all modules -->
+ <dependencies>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>${junit.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <!-- Needed by junit -->
+ <dependency>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest-all</artifactId>
+ <version>${hamcrest.version}</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+
<build>
<plugins>
<plugin>
@@ -238,7 +259,9 @@
<exclude>**/.project</exclude>
<exclude>**/.settings/*</exclude>
<exclude>site/**</exclude>
+ <exclude>.repository/**</exclude>
</excludes>
+ <consoleOutput>true</consoleOutput>
</configuration>
</plugin>
</plugins>
--
To stop receiving notification emails like this one, please contact
['"commits@bookkeeper.apache.org" <co...@bookkeeper.apache.org>'].