You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/12/08 12:43:43 UTC
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on a change in pull request #828: (ios): add statusbar 'darkcontent'
timbru31 commented on a change in pull request #828:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/828#discussion_r538323980
##########
File path: src/ios/CDVWKInAppBrowser.m
##########
@@ -1067,6 +1067,12 @@ - (UIStatusBarStyle)preferredStatusBarStyle
NSString* statusBarStylePreference = [self settingForKey:@"InAppBrowserStatusBarStyle"];
if (statusBarStylePreference && [statusBarStylePreference isEqualToString:@"lightcontent"]) {
return UIStatusBarStyleLightContent;
+ } else if (statusBarStylePreference && [statusBarStylePreference isEqualToString:@"darkcontent"]) {
+ if (@available(iOS 13.0, *)) {
+ return UIStatusBarStyleDarkContent;
Review comment:
```suggestion
return UIStatusBarStyleDarkContent;
```
a bit nitpicky, but there is a space too much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org