[GitHub] [trafficserver-ingress-controller] rishabhc commented on a change in pull request #16: Build - Adds dockerhub username and password

[GitBox <gi...@apache.org>]

rishabhc commented on a change in pull request #16:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/16#discussion_r459142041



##########
File path: build-master.sh
##########
@@ -3,10 +3,8 @@
 # build
 REPONAME="ats-ingress"
 TAG="latest"
-#TARGET="quay.io"/${QUAY_USERNAME}/${REPONAME}:${TAG}
-TARGET="ats-ingress:latest"
-#echo ${TARGET}
+TARGET=atsingress/${REPONAME}:${TAG}

Review comment:
       the final target has to be atsingress/ats-ingress:latest
   atsingress is the organization name on docker hub (which i created) while ats-ingress is the repo name. org name can only have letters and numbers on dockerhub 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org