You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by WireBaron <gi...@git.apache.org> on 2017/07/18 23:04:14 UTC
[GitHub] geode pull request #643: GEODE-3192,GEODE-3229: Change API and implementatio...
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/643
GEODE-3192,GEODE-3229: Change API and implementation of protobuf PutAll.
@kohlmu-pivotal @pivotal-amurmann @galen-pivotal @bschuchardt @hiteshk25
* We will now dispatch incoming protobuf PutAlls as a series of put operations
* The PutAllResponse will contain a set of failed keys and the error they failed with
Signed-off-by: Galen O'Sullivan <go...@pivotal.io>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/WireBaron/geode feature/GEODE-3229
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/643.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #643
----
commit a056814b30f76572dca68abea57895d4be670da2
Author: Brian Rowe <br...@pivotal.io>
Date: 2017-07-18T21:52:50Z
GEODE-3192,GEODE-3229: Change API and implementation of protobuf PutAll.
* We will now dispatch incoming protobuf PutAlls as a series of put operations
* The PutAllResponse will contain a set of failed keys and the error they failed with
Signed-off-by: Galen O'Sullivan <go...@pivotal.io>
Signed-off-by: Brian Rowe <br...@pivotal.io>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #643: GEODE-3192,GEODE-3229: Change API and implementation of pr...
Posted by PurelyApplied <gi...@git.apache.org>.
Github user PurelyApplied commented on the issue:
https://github.com/apache/geode/pull/643
If you are using IntelliJ as your IDE, please remember to update your style file to that located in `geode/etc/intellij-java-modified-google-style.xml` to be consistent with Geode's established style guide. This file was updated June 13 with commit `a561bd12` to be consistent with documented expectations. If you are using Eclipse, please import both style guide files, also located in `geode/etc/`.
After having done so, please optimize the imports to the correct order in each of the `.java` files touched.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #643: GEODE-3192,GEODE-3229: Change API and implementatio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/643
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #643: GEODE-3192,GEODE-3229: Change API and implementatio...
Posted by galen-pivotal <gi...@git.apache.org>.
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/643#discussion_r129649690
--- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java ---
@@ -53,10 +52,10 @@
ProtobufUtilities.createEncodedValue(serializationService, resultValue);
return Success.of(RegionAPI.GetResponse.newBuilder().setResult(encodedValue).build());
} catch (UnsupportedEncodingTypeException ex) {
- return Failure.of(
- ClientProtocol.ErrorResponse.newBuilder().setMessage("Encoding not supported.").build());
+ return Failure
--- End diff --
We're not entirely consistent with when we log errors and when we don't. Probably these should be logged like the others?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---