[GitHub] [solr] risdenk commented on a diff in pull request #1134: SOLR-16293: Luke request fails for document with a binary field

[GitBox <gi...@apache.org>]

risdenk commented on code in PR #1134:
URL: https://github.com/apache/solr/pull/1134#discussion_r1006101860


##########
solr/core/src/java/org/apache/solr/handler/admin/LukeRequestHandler.java:
##########
@@ -341,10 +342,9 @@ private static SimpleOrderedMap<Object> getDocumentFieldsInfo(
                     .array(),
                 StandardCharsets.ISO_8859_1));
       }
-      if (!ftype.isPointField()) {
+      if (ftype != null && !ftype.isPointField()) {
         Term t =
-            new Term(
-                field.name(), ftype != null ? ftype.storedToIndexed(field) : field.stringValue());

Review Comment:
   ftype is always nonnull - otherwise `ftype.isPointField` would blow up. This simplifies the `new Term` call. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org