[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

["Yu Li (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453769#comment-17453769 ] 

Yu Li commented on HBASE-24640:
-------------------------------

Just a note here, that please use {{com.google.errorprone.annotations.RestrictedApi}} instead when you need to expose some methods for testing purpose in {{IA.Private}} classes. More details please refer to HBASE-25333.

> Purge use of VisibleForTesting
> ------------------------------
>
>                 Key: HBASE-24640
>                 URL: https://issues.apache.org/jira/browse/HBASE-24640
>             Project: HBase
>          Issue Type: Task
>          Components: community
>    Affects Versions: 3.0.0-alpha-1, 2.4.0
>            Reporter: Nick Dimiduk
>            Assignee: Andrew Kyle Purtell
>            Priority: Major
>             Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0
>
>
> From the dev-list thread ["[DISCUSS] VisibleForTesting annotation as it pertains to our API compatibility guidelines"|https://lists.apache.org/thread.html/rc7c7c66f134fe135d0a4454a883215e26ff3d20e5a31ecd6a2d1db77%40%3Cdev.hbase.apache.org%3E], when used in classes annotated with interface audience other than IA.Private, the VisibleForTesting annotation is confusing and considered harmful. The consensus is that we do not want to use this annotation as part of the definition of our public APIs, and we need to remove the point of confusion.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)