You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "qqu0127 (via GitHub)" <gi...@apache.org> on 2023/05/15 22:08:58 UTC
[GitHub] [helix] qqu0127 commented on a diff in pull request #2457: Lattice LockClient Implementation
qqu0127 commented on code in PR #2457:
URL: https://github.com/apache/helix/pull/2457#discussion_r1194405918
##########
meta-client/src/main/java/org/apache/helix/metaclient/recipes/lock/LockClient.java:
##########
@@ -0,0 +1,108 @@
+package org.apache.helix.metaclient.recipes.lock;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+
+import org.apache.helix.metaclient.api.MetaClientInterface;
+import org.apache.helix.metaclient.api.Op;
+import org.apache.helix.metaclient.datamodel.DataRecord;
+import org.apache.helix.metaclient.exception.MetaClientException;
+import org.apache.helix.metaclient.factories.MetaClientConfig;
+import org.apache.helix.metaclient.factories.MetaClientFactory;
+import org.apache.helix.metaclient.impl.zk.factory.ZkMetaClientConfig;
+import org.apache.helix.metaclient.impl.zk.factory.ZkMetaClientFactory;
+import org.apache.helix.zookeeper.datamodel.serializer.ZNRecordSerializer;
+
+import java.util.Arrays;
+import java.util.List;
+
+public class LockClient implements LockClientInterface, AutoCloseable {
+ private final MetaClientInterface<LockInfo> _metaClient;
+
+ public LockClient(MetaClientConfig config) {
+ if (config.getStoreType().equals(MetaClientConfig.StoreType.ZOOKEEPER)) {
+ ZkMetaClientConfig zkMetaClientConfig = new ZkMetaClientConfig.ZkMetaClientConfigBuilder().
+ setConnectionAddress(config.getConnectionAddress())
+ // Currently only support ZNRecordSerializer. TODO: make this configurable
+ .setZkSerializer((new ZNRecordSerializer()))
+ .build();
+ _metaClient = new ZkMetaClientFactory().getMetaClient(zkMetaClientConfig);
+ } else {
+ throw new MetaClientException("Unsupported store type: " + config.getStoreType());
+ }
+ _metaClient.connect();
+ }
+
+ public LockClient(MetaClientInterface<LockInfo> client) {
+ _metaClient = client;
+ _metaClient.connect();
+ }
+
+ @Override
+ public void acquireLock(String key, LockInfo lockInfo, MetaClientInterface.EntryMode mode) {
+ _metaClient.create(key, lockInfo, mode);
+ }
+
+ @Override
+ public void acquireLockWithTTL(String key, LockInfo lockInfo, long ttl) {
+ _metaClient.createWithTTL(key, lockInfo, ttl);
+ }
+
+ @Override
+ public void renewTTLLock(String key) {
+ _metaClient.renewTTLNode(key);
+ }
+
+ @Override
+ public void releaseLock(String key) {
+ MetaClientInterface.Stat stat = _metaClient.exists(key);
+ if (stat != null) {
+ int version = stat.getVersion();
+ List<Op> ops = Arrays.asList(
+ Op.check(key, version),
+ Op.delete(key, version));
+ _metaClient.transactionOP(ops);
+ if (_metaClient.exists(key) != null) {
+ throw new MetaClientException("Failed to release lock for key: " + key);
+ }
+ }
+ }
+
+ @Override
+ public LockInfo retrieveLock(String key) {
+ MetaClientInterface.Stat stat = _metaClient.exists(key);
+ if (stat == null) {
+ return null;
+ }
+ //Create a new DataRecord from underlying record
+ DataRecord dataRecord = new DataRecord(_metaClient.get(key));
+ //Create a new LockInfo from DataRecord
+ LockInfo lockInfo = new LockInfo(dataRecord);
+ //Synchronize the lockInfo with the stat
+ lockInfo.setGrantedAt(stat.getCreationTime());
+ lockInfo.setLastRenewedAt(stat.getModifiedTime());
+ return lockInfo;
+ }
+
+ @Override
+ public void close() {
+ _metaClient.disconnect();
Review Comment:
If user uses the constructor `public LockClient(MetaClientInterface<LockInfo> client)`, the metaclient shouldn't be closed, it will have external unexpected effect.
##########
meta-client/src/main/java/org/apache/helix/metaclient/recipes/lock/LockClient.java:
##########
@@ -0,0 +1,107 @@
+package org.apache.helix.metaclient.recipes.lock;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+
+import org.apache.helix.metaclient.api.MetaClientInterface;
+import org.apache.helix.metaclient.api.Op;
+import org.apache.helix.metaclient.datamodel.DataRecord;
+import org.apache.helix.metaclient.exception.MetaClientException;
+import org.apache.helix.metaclient.factories.MetaClientConfig;
+import org.apache.helix.metaclient.factories.MetaClientFactory;
+import org.apache.helix.metaclient.impl.zk.factory.ZkMetaClientConfig;
+import org.apache.helix.metaclient.impl.zk.factory.ZkMetaClientFactory;
+import org.apache.helix.zookeeper.datamodel.serializer.ZNRecordSerializer;
+
+import java.util.Arrays;
+import java.util.List;
+
+public class LockClient implements LockClientInterface, AutoCloseable {
+ private final MetaClientInterface<LockInfo> _metaClient;
+
+ public LockClient(MetaClientConfig config) {
+ if (!config.getStoreType().equals(MetaClientConfig.StoreType.ZOOKEEPER)) {
+ throw new MetaClientException("Unsupported store type: " + config.getStoreType());
+ }
+ ZkMetaClientConfig zkMetaClientConfig = new ZkMetaClientConfig.ZkMetaClientConfigBuilder().
+ setConnectionAddress(config.getConnectionAddress())
+ // Currently only support ZNRecordSerializer. TODO: make this configurable
+ .setZkSerializer((new ZNRecordSerializer()))
+ .build();
+ _metaClient = new ZkMetaClientFactory().getMetaClient(zkMetaClientConfig);
+ _metaClient.connect();
+ }
+
+ public LockClient(MetaClientInterface<LockInfo> client) {
+ _metaClient = client;
+ _metaClient.connect();
+ }
+
+ @Override
+ public void acquireLock(String key, LockInfo lockInfo, MetaClientInterface.EntryMode mode) {
+ _metaClient.create(key, lockInfo, mode);
+ }
+
+ @Override
+ public void acquireLockWithTTL(String key, LockInfo lockInfo, long ttl) {
+ _metaClient.createWithTTL(key, lockInfo, ttl);
+ }
+
+ @Override
+ public void renewTTLLock(String key) {
+ _metaClient.renewTTLNode(key);
+ }
+
+ @Override
+ public void releaseLock(String key) {
+ MetaClientInterface.Stat stat = _metaClient.exists(key);
+ if (stat != null) {
+ int version = stat.getVersion();
+ List<Op> ops = Arrays.asList(
+ Op.check(key, version),
+ Op.delete(key, version));
+ _metaClient.transactionOP(ops);
+ if (_metaClient.exists(key) != null) {
+ throw new MetaClientException("Failed to release lock for key: " + key);
+ }
+ }
+ }
+
+ @Override
+ public LockInfo retrieveLock(String key) {
+ MetaClientInterface.Stat stat = _metaClient.exists(key);
+ if (stat == null) {
+ return null;
+ }
+ //Create a new DataRecord from underlying record
+ DataRecord dataRecord = new DataRecord(_metaClient.get(key));
+ //Create a new LockInfo from DataRecord
+ LockInfo lockInfo = new LockInfo(dataRecord);
+ //Synchronize the lockInfo with the stat
+ lockInfo.setGrantedAt(stat.getCreationTime());
+ lockInfo.setLastRenewedAt(stat.getModifiedTime());
Review Comment:
nit: can this be wrapped into a constructor?
##########
meta-client/src/main/java/org/apache/helix/metaclient/recipes/lock/LockClient.java:
##########
@@ -0,0 +1,107 @@
+package org.apache.helix.metaclient.recipes.lock;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+
+import org.apache.helix.metaclient.api.MetaClientInterface;
+import org.apache.helix.metaclient.api.Op;
+import org.apache.helix.metaclient.datamodel.DataRecord;
+import org.apache.helix.metaclient.exception.MetaClientException;
+import org.apache.helix.metaclient.factories.MetaClientConfig;
+import org.apache.helix.metaclient.factories.MetaClientFactory;
+import org.apache.helix.metaclient.impl.zk.factory.ZkMetaClientConfig;
+import org.apache.helix.metaclient.impl.zk.factory.ZkMetaClientFactory;
+import org.apache.helix.zookeeper.datamodel.serializer.ZNRecordSerializer;
+
+import java.util.Arrays;
+import java.util.List;
+
+public class LockClient implements LockClientInterface, AutoCloseable {
+ private final MetaClientInterface<LockInfo> _metaClient;
+
+ public LockClient(MetaClientConfig config) {
+ if (!config.getStoreType().equals(MetaClientConfig.StoreType.ZOOKEEPER)) {
Review Comment:
let's follow Junkai's comment to avoid NPE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org