You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2009/04/29 23:19:30 UTC

[jira] Created: (THRIFT-472) Don't allow unquoted strings at all

Don't allow unquoted strings at all
-----------------------------------

                 Key: THRIFT-472
                 URL: https://issues.apache.org/jira/browse/THRIFT-472
             Project: Thrift
          Issue Type: Improvement
          Components: Compiler (General)
    Affects Versions: 0.1
            Reporter: Bryan Duxbury
            Priority: Minor


If you are working with constants in Thrift and happen to write a string without quotes, the compiler will warn you about using unquoted strings, but it's not an error. This can lead to some confusing debugging if you actually mistyped an enum value's constant or the like. 

I propose that rather than having such a thing as an "unquoted string", we just check if it's a constant, and if not error out. It seems like it would decrease the potential complexities without really sacrificing any functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (THRIFT-472) Don't allow unquoted strings at all

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704362#action_12704362 ] 

David Reiss commented on THRIFT-472:
------------------------------------

+1

> Don't allow unquoted strings at all
> -----------------------------------
>
>                 Key: THRIFT-472
>                 URL: https://issues.apache.org/jira/browse/THRIFT-472
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (General)
>    Affects Versions: 0.1
>            Reporter: Bryan Duxbury
>            Priority: Minor
>
> If you are working with constants in Thrift and happen to write a string without quotes, the compiler will warn you about using unquoted strings, but it's not an error. This can lead to some confusing debugging if you actually mistyped an enum value's constant or the like. 
> I propose that rather than having such a thing as an "unquoted string", we just check if it's a constant, and if not error out. It seems like it would decrease the potential complexities without really sacrificing any functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.