You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2014/01/29 12:02:10 UTC
[jira] [Commented] (LUCENE-5398) NormValueSource unable to read
long field norm
[ https://issues.apache.org/jira/browse/LUCENE-5398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885228#comment-13885228 ]
Michael McCandless commented on LUCENE-5398:
--------------------------------------------
Thanks Peng, I'll have a look. It's clear that cast to (byte) is a holdover from before TFIDFSim only accepted 1 byte norms.
> NormValueSource unable to read long field norm
> ----------------------------------------------
>
> Key: LUCENE-5398
> URL: https://issues.apache.org/jira/browse/LUCENE-5398
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/query/scoring
> Affects Versions: 4.6
> Environment: Ubuntu 12.04
> Reporter: Peng Cheng
> Priority: Trivial
> Fix For: 4.7
>
> Attachments: NormValueSource.java, TestValueSourcesWithNonByteNormEncoding.java
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Previous Lucene implementation store field norms of all documents in memory, float values are therefore encoded into byte to minimize memory consumption.
> Recent release no longer have this constraint (see LUCENE-5078, and discussion at http://lucene.markmail.org/message/jtwit3pwu5oiqr2h), users are encouraged to implement their own encodeNormValue() to encode them into/decode from any type including int, byte and long, to fulfil their request for precision.
> But the legacy NormValueSource still typecast any long encoding into byte, as seen in line 74 in the java file, making any TFIDFSimilarity using more accurate encoding useless.
> It should be removed for the greater good.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org