You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2021/12/06 08:44:51 UTC
[ofbiz-framework] branch trunk updated (ca03e21 -> d6c18f2)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git.
from ca03e21 Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
new b02255a Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
new d6c18f2 Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../base/src/main/java/org/apache/ofbiz/base/util/ReferenceCleaner.java | 1 -
.../src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
[ofbiz-framework] 01/02: Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
Posted by jl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
commit b02255ae5fa54b27368b90be46853ae276c43a28
Author: Jacques Le Roux <ja...@les7arts.com>
AuthorDate: Mon Dec 6 09:43:52 2021 +0100
Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
No functional change: removes unused MODULE in ReferenceCleaner class
---
.../base/src/main/java/org/apache/ofbiz/base/util/ReferenceCleaner.java | 1 -
1 file changed, 1 deletion(-)
diff --git a/framework/base/src/main/java/org/apache/ofbiz/base/util/ReferenceCleaner.java b/framework/base/src/main/java/org/apache/ofbiz/base/util/ReferenceCleaner.java
index e0b2f73..4d6e6fe 100644
--- a/framework/base/src/main/java/org/apache/ofbiz/base/util/ReferenceCleaner.java
+++ b/framework/base/src/main/java/org/apache/ofbiz/base/util/ReferenceCleaner.java
@@ -24,7 +24,6 @@ import java.lang.ref.SoftReference;
import java.lang.ref.WeakReference;
public final class ReferenceCleaner {
- private static final String MODULE = ReferenceCleaner.class.getName();
private static final class CleanerThread extends Thread {
private boolean keepRunning = true;
[ofbiz-framework] 02/02: Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
Posted by jl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
commit d6c18f2998e8b0cc3af398ae19ee2e05f83215d8
Author: Jacques Le Roux <ja...@les7arts.com>
AuthorDate: Mon Dec 6 09:44:48 2021 +0100
Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
ModelFormField::isAllChecked can't return null, must be a boolean
---
.../src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java b/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
index c887d79..26db8eb 100644
--- a/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
+++ b/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
@@ -1114,7 +1114,7 @@ public final class ModelFormField {
if (!allCheckedStr.isEmpty()) {
return "true".equals(allCheckedStr);
}
- return null;
+ return false;
}
@Override