You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/12/08 14:22:30 UTC
[GitHub] [cloudstack-primate] ravening opened a new pull request #893: Dont pass account/domainid for upload sslcert in project view
ravening opened a new pull request #893:
URL: https://github.com/apache/cloudstack-primate/pull/893
In project view, we can upload ssl certificate either by using
projectid or accountid/domainid combination. Since we are passing
all 3 parameters, we cant upload sslcert in project view
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] ravening commented on pull request #893: Dont pass account/domainid for upload sslcert in project view
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #893:
URL: https://github.com/apache/cloudstack-primate/pull/893#issuecomment-748856304
> @ravening This will make the form require the user to enter the account as well as domain which is redundant as he's already navigated to the desired account. Instead, would it be better to exclude passing the projectid if the current route contains "account" over at https://github.com/apache/cloudstack-primate/blob/master/src/utils/request.js#L83 ?
>
>
@davidjumani we don't need to enter anything here. If we are in project view then project id is passed else account/domain will be taken from backend code
If we pass both account and domain in project view then exception is thrown
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #893: Dont pass account/domainid for upload sslcert in project view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #893:
URL: https://github.com/apache/cloudstack-primate/pull/893#issuecomment-748806375
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #893: Dont pass account/domainid for upload sslcert in project view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #893:
URL: https://github.com/apache/cloudstack-primate/pull/893#issuecomment-748810795
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/893 (JID-3755)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #893: Dont pass account/domainid for upload sslcert in project view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #893:
URL: https://github.com/apache/cloudstack-primate/pull/893#issuecomment-748860524
@ravening The account will be taken for the current user but say an admin will have to pass the account and domain while adding a certificate for another account, after having navigated to that account
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #893: Dont pass account/domainid for upload sslcert in project view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #893:
URL: https://github.com/apache/cloudstack-primate/pull/893#issuecomment-748814869
@ravening This will make the form require the user to enter the account as well as domain which is redundant as he's already navigated to the desired account. Instead, would it be better to exclude passing the projectid if the current route contains "account" over at https://github.com/apache/cloudstack-primate/blob/master/src/utils/request.js#L83 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #893: Dont pass account/domainid for upload sslcert in project view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #893:
URL: https://github.com/apache/cloudstack-primate/pull/893#issuecomment-748805997
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #893: Dont pass account/domainid for upload sslcert in project view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #893:
URL: https://github.com/apache/cloudstack-primate/pull/893#issuecomment-759849878
Ping @ravening any update on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] weizhouapache commented on pull request #893: Dont pass account/domainid for upload sslcert in project view
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #893:
URL: https://github.com/apache/cloudstack-primate/pull/893#issuecomment-760081405
@ravening @rhtyd @davidjumani
can we do like this ?
(1) in project view, ssl cert will be uploaded to project account, no matter what current account is.
otherwise there is no way to upload ssl cert to a project.
(2) in normal view, ssl cert will be uploaded to the current account on web page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org