You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/16 00:56:34 UTC

[GitHub] [superset] ktmud commented on pull request #12998: feat(explore): Execute predicate query string if set

ktmud commented on pull request #12998:
URL: https://github.com/apache/superset/pull/12998#issuecomment-779516758


   From the code it seems this only applies to `FilterBox`, but the screenshot shows histogram. Is it only for demonstration's purpose?
   
   The autocomplete predicate query string is used for this dropdown:
   
   <img src="https://user-images.githubusercontent.com/335541/108005026-65541780-6fac-11eb-97c9-d656bec24482.png" width="400">
   
   which then calls [`/filter/<datasource_type>/<datasource_id>/<column>`](https://github.com/apache/superset/blob/d7cbd53fce2c6ec2301d99bfda0b1969e5ec36e5/superset/views/core.py#L836) and [`values_for_column`](https://github.com/apache/superset/blob/eeec2140656ed862531252c69dfd616a91f8ce74/superset/connectors/sqla/models.py#L723). I'm wondering whether we should just reuse this API for FilterBox, too?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org