You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Babiichuk <ab...@hortonworks.com> on 2018/01/05 19:34:29 UTC
Review Request 64988: Log Search UI: implement graph for access logs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64988/
-----------------------------------------------------------
Review request for Ambari and Denys Buzhor.
Bugs: AMBARI-22741
https://issues.apache.org/jira/browse/AMBARI-22741
Repository: ambari
Description
-------
Line chart with time-dependent counts of access events from different sources should be implemented.
Diffs
-----
ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts da78a71
ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/graph.component.less 0830193
ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/graph.component.ts 1bb7f92
ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/time-graph.component.less PRE-CREATION
ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/time-graph.component.ts PRE-CREATION
ambari-logsearch/ambari-logsearch-web/src/app/classes/graph.ts 3992828
ambari-logsearch/ambari-logsearch-web/src/app/classes/models/store.ts f996d92
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-graph-query-params.spec.ts PRE-CREATION
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-graph-query-params.ts PRE-CREATION
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.spec.ts eb891ed
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.ts 148aa62
ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-entries/audit-logs-entries.component.html 3c5852a
ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-entries/audit-logs-entries.component.spec.ts 260b383
ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.spec.ts b6206db
ambari-logsearch/ambari-logsearch-web/src/app/components/collapsible-panel/collapsible-panel.component.html 4d0bd39
ambari-logsearch/ambari-logsearch-web/src/app/components/collapsible-panel/collapsible-panel.component.spec.ts 5f5f1b0
ambari-logsearch/ambari-logsearch-web/src/app/components/collapsible-panel/collapsible-panel.component.ts f82823a
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts 9f2bb16
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.spec.ts 63824cb
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts 082082c
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts d085f3e
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts c9f9b52
ambari-logsearch/ambari-logsearch-web/src/app/components/horizontal-histogram/horizontal-histogram.component.ts 9553e2e
ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.spec.ts 7bd87ad
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html 8e507ae
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.spec.ts 2bb8731
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts 6d50a17
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts 67d9423
ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.spec.ts 0c323f7
ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.html 720f55e
ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.less 364517c
ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.spec.ts 09cd5d8
ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.ts 8544677
ambari-logsearch/ambari-logsearch-web/src/app/components/time-line-graph/time-line-graph.component.html PRE-CREATION
ambari-logsearch/ambari-logsearch-web/src/app/components/time-line-graph/time-line-graph.component.less PRE-CREATION
ambari-logsearch/ambari-logsearch-web/src/app/components/time-line-graph/time-line-graph.component.spec.ts PRE-CREATION
ambari-logsearch/ambari-logsearch-web/src/app/components/time-line-graph/time-line-graph.component.ts PRE-CREATION
ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.spec.ts 43e4bd5
ambari-logsearch/ambari-logsearch-web/src/app/components/timezone-picker/timezone-picker.component.spec.ts ab56589
ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.spec.ts ba5b613
ambari-logsearch/ambari-logsearch-web/src/app/mock-data.ts aa86f4f
ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.spec.ts c2cee8d
ambari-logsearch/ambari-logsearch-web/src/app/services/component-generator.service.spec.ts 3f65cd1
ambari-logsearch/ambari-logsearch-web/src/app/services/http-client.service.ts 6f98bf5
ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.spec.ts acdc0c2
ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts 78bcdb1
ambari-logsearch/ambari-logsearch-web/src/app/services/storage/audit-logs-graph-data.service.ts PRE-CREATION
ambari-logsearch/ambari-logsearch-web/src/app/services/storage/reducers.service.ts d700b16
ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 48c1d88
Diff: https://reviews.apache.org/r/64988/diff/1/
Testing
-------
Executed 242 of 242 SUCCESS (5.417 secs / 5.343 secs)
Thanks,
Andrii Babiichuk
Re: Review Request 64988: Log Search UI: implement graph for access
logs
Posted by Denys Buzhor <bd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64988/#review194892
-----------------------------------------------------------
Ship it!
Ship It!
- Denys Buzhor
On Jan. 5, 2018, 7:34 p.m., Andrii Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64988/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 7:34 p.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: AMBARI-22741
> https://issues.apache.org/jira/browse/AMBARI-22741
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Line chart with time-dependent counts of access events from different sources should be implemented.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts da78a71
> ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/graph.component.less 0830193
> ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/graph.component.ts 1bb7f92
> ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/time-graph.component.less PRE-CREATION
> ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/time-graph.component.ts PRE-CREATION
> ambari-logsearch/ambari-logsearch-web/src/app/classes/graph.ts 3992828
> ambari-logsearch/ambari-logsearch-web/src/app/classes/models/store.ts f996d92
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-graph-query-params.spec.ts PRE-CREATION
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-graph-query-params.ts PRE-CREATION
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.spec.ts eb891ed
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.ts 148aa62
> ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-entries/audit-logs-entries.component.html 3c5852a
> ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-entries/audit-logs-entries.component.spec.ts 260b383
> ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.spec.ts b6206db
> ambari-logsearch/ambari-logsearch-web/src/app/components/collapsible-panel/collapsible-panel.component.html 4d0bd39
> ambari-logsearch/ambari-logsearch-web/src/app/components/collapsible-panel/collapsible-panel.component.spec.ts 5f5f1b0
> ambari-logsearch/ambari-logsearch-web/src/app/components/collapsible-panel/collapsible-panel.component.ts f82823a
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts 9f2bb16
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.spec.ts 63824cb
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts 082082c
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts d085f3e
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts c9f9b52
> ambari-logsearch/ambari-logsearch-web/src/app/components/horizontal-histogram/horizontal-histogram.component.ts 9553e2e
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.spec.ts 7bd87ad
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html 8e507ae
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.spec.ts 2bb8731
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts 6d50a17
> ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts 67d9423
> ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.spec.ts 0c323f7
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.html 720f55e
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.less 364517c
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.spec.ts 09cd5d8
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.ts 8544677
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-line-graph/time-line-graph.component.html PRE-CREATION
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-line-graph/time-line-graph.component.less PRE-CREATION
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-line-graph/time-line-graph.component.spec.ts PRE-CREATION
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-line-graph/time-line-graph.component.ts PRE-CREATION
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.spec.ts 43e4bd5
> ambari-logsearch/ambari-logsearch-web/src/app/components/timezone-picker/timezone-picker.component.spec.ts ab56589
> ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.spec.ts ba5b613
> ambari-logsearch/ambari-logsearch-web/src/app/mock-data.ts aa86f4f
> ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.spec.ts c2cee8d
> ambari-logsearch/ambari-logsearch-web/src/app/services/component-generator.service.spec.ts 3f65cd1
> ambari-logsearch/ambari-logsearch-web/src/app/services/http-client.service.ts 6f98bf5
> ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.spec.ts acdc0c2
> ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts 78bcdb1
> ambari-logsearch/ambari-logsearch-web/src/app/services/storage/audit-logs-graph-data.service.ts PRE-CREATION
> ambari-logsearch/ambari-logsearch-web/src/app/services/storage/reducers.service.ts d700b16
> ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 48c1d88
>
>
> Diff: https://reviews.apache.org/r/64988/diff/1/
>
>
> Testing
> -------
>
> Executed 242 of 242 SUCCESS (5.417 secs / 5.343 secs)
>
>
> Thanks,
>
> Andrii Babiichuk
>
>