You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/02 13:00:49 UTC
[GitHub] [hudi] KnightChess opened a new pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
KnightChess opened a new pull request #5215:
URL: https://github.com/apache/hudi/pull/5215
## What is the purpose of the pull request
fix can not delete record by use spark sql. operation.key must be "delete"
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086865109
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
}, {
"hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781",
"triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"triggerType" : "PUSH"
}, {
"hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786",
"triggerID" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"triggerType" : "PUSH"
}, {
"hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7789",
"triggerID" : "1086837609",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7789)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086816297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
}, {
"hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781",
"triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"triggerType" : "PUSH"
}, {
"hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e4560a3b477781f77ae3295340c31e4d7ce4b526 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781)
* 79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086637054
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11b8b2b4c6a6e0d09c5ef689e5223f663f588def Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086636273
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11b8b2b4c6a6e0d09c5ef689e5223f663f588def UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess commented on a change in pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
KnightChess commented on a change in pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#discussion_r841162307
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/DeleteHoodieTableCommand.scala
##########
@@ -65,7 +65,7 @@ case class DeleteHoodieTableCommand(deleteTable: DeleteFromTable) extends Hoodie
assert(hoodieCatalogTable.primaryKeys.nonEmpty,
s"There are no primary key defined in table $tableId, cannot execute delete operator")
- withSparkConf(sparkSession, hoodieCatalogTable.catalogProperties) {
+ val globalConf = withSparkConf(sparkSession, hoodieCatalogTable.catalogProperties) {
Review comment:
looks great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086816705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
}, {
"hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781",
"triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"triggerType" : "PUSH"
}, {
"hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786",
"triggerID" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e4560a3b477781f77ae3295340c31e4d7ce4b526 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781)
* 79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086637054
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11b8b2b4c6a6e0d09c5ef689e5223f663f588def Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086780119
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
}, {
"hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781",
"triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11b8b2b4c6a6e0d09c5ef689e5223f663f588def Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756)
* e4560a3b477781f77ae3295340c31e4d7ce4b526 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086816297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
}, {
"hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781",
"triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"triggerType" : "PUSH"
}, {
"hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e4560a3b477781f77ae3295340c31e4d7ce4b526 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781)
* 79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086831543
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
}, {
"hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781",
"triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"triggerType" : "PUSH"
}, {
"hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786",
"triggerID" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars removed a comment on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars removed a comment on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086837609
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086658547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11b8b2b4c6a6e0d09c5ef689e5223f663f588def Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086779840
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
}, {
"hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11b8b2b4c6a6e0d09c5ef689e5223f663f588def Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756)
* e4560a3b477781f77ae3295340c31e4d7ce4b526 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086816705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
}, {
"hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781",
"triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"triggerType" : "PUSH"
}, {
"hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786",
"triggerID" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e4560a3b477781f77ae3295340c31e4d7ce4b526 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781)
* 79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086803537
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
}, {
"hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781",
"triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e4560a3b477781f77ae3295340c31e4d7ce4b526 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086636273
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11b8b2b4c6a6e0d09c5ef689e5223f663f588def UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086831543
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
}, {
"hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781",
"triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"triggerType" : "PUSH"
}, {
"hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786",
"triggerID" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars commented on a change in pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on a change in pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#discussion_r841160198
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/DeleteHoodieTableCommand.scala
##########
@@ -65,7 +65,7 @@ case class DeleteHoodieTableCommand(deleteTable: DeleteFromTable) extends Hoodie
assert(hoodieCatalogTable.primaryKeys.nonEmpty,
s"There are no primary key defined in table $tableId, cannot execute delete operator")
- withSparkConf(sparkSession, hoodieCatalogTable.catalogProperties) {
+ val globalConf = withSparkConf(sparkSession, hoodieCatalogTable.catalogProperties) {
Review comment:
change to `val options: Map[String, String] = hoodieCatalogTable.catalogProperties.-(OPERATION.key)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086837947
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
}, {
"hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781",
"triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"triggerType" : "PUSH"
}, {
"hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786",
"triggerID" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"triggerType" : "PUSH"
}, {
"hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7789",
"triggerID" : "1086837609",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7789)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086658547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11b8b2b4c6a6e0d09c5ef689e5223f663f588def Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086779840
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
}, {
"hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11b8b2b4c6a6e0d09c5ef689e5223f663f588def Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756)
* e4560a3b477781f77ae3295340c31e4d7ce4b526 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086837947
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
}, {
"hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781",
"triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"triggerType" : "PUSH"
}, {
"hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786",
"triggerID" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"triggerType" : "PUSH"
}, {
"hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7789",
"triggerID" : "1086837609",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7789)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086837609
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086780119
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
}, {
"hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781",
"triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11b8b2b4c6a6e0d09c5ef689e5223f663f588def Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756)
* e4560a3b477781f77ae3295340c31e4d7ce4b526 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1086803537
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
"triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
"triggerType" : "PUSH"
}, {
"hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781",
"triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e4560a3b477781f77ae3295340c31e4d7ce4b526 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org