Re: Early review of DUCC pre-release - test code in non-standard place

[Marshall Schor <ms...@schor.com>]

I see some classes that look like tests in the main (non-test) source tree of at
least one project: uima-ducc-cli (see for instance,
org.apache.uima.ducc.cli.ws.json, there are classes "MachineFactsTest" and
"ReservationFactsTest". 

I think these should be moved to the normal maven spot (convention over
configuration :-) ), so they get run automatically during the build (they would
need to be turned into junit tests too).

A scan of the code shows 9 classes with the word "test" as part of the name, and
none of these are in the src/test/java conventional spot, so none of the tests
are being run as part of the build, I think (I didn't check...).



-Marshall

Re: Early review of DUCC pre-release - test code in non-standard place

[Lou DeGenaro <lo...@gmail.com>]

My claim is that as of now, all hits on the string "test" or "Test" when
grepping .java's in DUCC are legit.  Hopefully this resolves
MachineFactsTest" and "ReservationFactsTest" and 9 others?

Note that there is a PamTest.java.  If its name is an issue I can change it
to perhaps PamCheck.java.  I happen to like it as it is, but will change if
that is the convention.

Also there are some packages in the examples project having "test" as a
part of the package name.  That's OK?

Lou.


On Thu, Nov 21, 2013 at 8:06 AM, Lou DeGenaro <lo...@gmail.com>wrote:

> Marshall,
>
> I'll look into the "MachineFactsTest" and "ReservationFactsTest" and 9
> others issue.  Thx!
>
> Lou.
>
>
> On Wed, Nov 20, 2013 at 9:05 PM, Marshall Schor <ms...@schor.com> wrote:
>
>> I see some classes that look like tests in the main (non-test) source
>> tree of at
>> least one project: uima-ducc-cli (see for instance,
>> org.apache.uima.ducc.cli.ws.json, there are classes "MachineFactsTest" and
>> "ReservationFactsTest".
>>
>> I think these should be moved to the normal maven spot (convention over
>> configuration :-) ), so they get run automatically during the build (they
>> would
>> need to be turned into junit tests too).
>>
>> A scan of the code shows 9 classes with the word "test" as part of the
>> name, and
>> none of these are in the src/test/java conventional spot, so none of the
>> tests
>> are being run as part of the build, I think (I didn't check...).
>>
>>
>>
>> -Marshall
>>
>
>

Re: Early review of DUCC pre-release - test code in non-standard place

[Lou DeGenaro <lo...@gmail.com>]

Marshall,

I'll look into the "MachineFactsTest" and "ReservationFactsTest" and 9
others issue.  Thx!

Lou.


On Wed, Nov 20, 2013 at 9:05 PM, Marshall Schor <ms...@schor.com> wrote:

> I see some classes that look like tests in the main (non-test) source tree
> of at
> least one project: uima-ducc-cli (see for instance,
> org.apache.uima.ducc.cli.ws.json, there are classes "MachineFactsTest" and
> "ReservationFactsTest".
>
> I think these should be moved to the normal maven spot (convention over
> configuration :-) ), so they get run automatically during the build (they
> would
> need to be turned into junit tests too).
>
> A scan of the code shows 9 classes with the word "test" as part of the
> name, and
> none of these are in the src/test/java conventional spot, so none of the
> tests
> are being run as part of the build, I think (I didn't check...).
>
>
>
> -Marshall
>