Re: svn commit: r541364 [1/2] - in /incubator/cxf/trunk: api/src/main/java/org/apache/cxf/endpoint/ rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/interceptor/ rt/core/src/main/java/org/apache/cxf/endpoint/ rt/core/src/main/resources/META-INF/c...

[Daniel Kulp <dk...@apache.org>]

Andrea,

If I'm reading this code correctly.....

The ClientLifeCycleManager holds on to all clients with strong 
references.  The only way to release it is to call "destroy()" on the 
client.   

That isn't a "normal" thing to do in a JAX-WS use case.   Thus, for 
normal JAX-WS development, all clients ever created are held onto 
forever.   All the resources they contain are never released.   Etc....

Am I reading that correctly?   If so, -1.   That needs to be fixed.


Dan



On Thursday 24 May 2007 13:33, andreasmyth@apache.org wrote:
> Author: andreasmyth
> Date: Thu May 24 10:33:11 2007
> New Revision: 541364
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=541364
> Log:
> [JIRA CXF-139] Client-side recovery.
> Added client lifecycle management interface to be notified of client
> creation so that recovery can take place before client sends any
> requests. Fixed minor bug in handling TerminateSequence invocation.
>
> Added:
>    
> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/endpoint/ClientLi
>feCycleListener.java   (with props)
> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/endpoint/ClientLi
>feCycleManager.java   (with props)
> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/endpoint/Clie
>ntLifeCycleManagerImpl.java   (with props)
> incubator/cxf/trunk/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/RMUtil
>sTest.java   (with props)
> incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/ws/r
>m/ClientPersistenceTest.java   (with props) Removed:
>    
> incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/ws/r
>m/PersistenceTest.java Modified:
>    
> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/endpoint/Client.j
>ava
> incubator/cxf/trunk/rt/bindings/soap/src/main/java/org/apache/cxf/bind
>ing/soap/interceptor/SoapHeaderInterceptor.java
> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/endpoint/Clie
>ntImpl.java
> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/endpoint/Serv
>erLifeCycleManagerImpl.java
> incubator/cxf/trunk/rt/core/src/main/resources/META-INF/cxf/cxf.xml
> incubator/cxf/trunk/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/Abstra
>ctEndpoint.java
> incubator/cxf/trunk/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/Proxy.
>java
> incubator/cxf/trunk/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/RMCont
>extUtils.java
> incubator/cxf/trunk/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/RMEndp
>oint.java
> incubator/cxf/trunk/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/RMMana
>ger.java
> incubator/cxf/trunk/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/RMOutI
>nterceptor.java
> incubator/cxf/trunk/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/RMUtil
>s.java
> incubator/cxf/trunk/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/Retran
>smissionQueue.java
> incubator/cxf/trunk/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/Servan
>t.java
> incubator/cxf/trunk/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/soap/R
>etransmissionQueueImpl.java
> incubator/cxf/trunk/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/Abstra
>ctEndpointTest.java
> incubator/cxf/trunk/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/ProxyT
>est.java
> incubator/cxf/trunk/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/RMEndp
>ointTest.java
> incubator/cxf/trunk/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/RMMana
>gerTest.java
> incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/ws/r
>m/oneway-client-crash.xml
>

-- 
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727    C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog