You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/03/31 12:47:43 UTC
[GitHub] [incubator-iceberg] chenjunjiedada opened a new pull request #885:
Add file_type to DataFile to support deletion file
chenjunjiedada opened a new pull request #885: Add file_type to DataFile to support deletion file
URL: https://github.com/apache/incubator-iceberg/pull/885
This is for https://github.com/apache/incubator-iceberg/issues/359.
I don't define the column equality delete file because we don't have a clear definition of schema yet. I think it would be `List< Map< fieldId: int, value: binary> >`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] prodeezy commented on issue #885: Add file_type
to DataFile to support deletion file
Posted by GitBox <gi...@apache.org>.
prodeezy commented on issue #885: Add file_type to DataFile to support deletion file
URL: https://github.com/apache/incubator-iceberg/pull/885#issuecomment-610051297
Linking this PR to https://github.com/apache/incubator-iceberg/issues/824 just so this is easy to find from the issue :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] chenjunjiedada commented on a change in pull
request #885: Add file_type to DataFile to support deletion file
Posted by GitBox <gi...@apache.org>.
chenjunjiedada commented on a change in pull request #885: Add file_type to DataFile to support deletion file
URL: https://github.com/apache/incubator-iceberg/pull/885#discussion_r404798990
##########
File path: core/src/main/java/org/apache/iceberg/GenericDataFile.java
##########
@@ -160,6 +161,14 @@ public GenericDataFile(org.apache.avro.Schema avroSchema) {
this.keyMetadata = ByteBuffers.toByteArray(keyMetadata);
}
+ GenericDataFile(String filePath, FileFormat format, PartitionData partition,
+ long fileSizeInBytes, Metrics metrics,
+ ByteBuffer keyMetadata, List<Long> splitOffsets, Integer fileType) {
+ this(filePath, format, partition, fileSizeInBytes, metrics, splitOffsets);
Review comment:
OK, no problem!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] prodeezy commented on a change in pull request
#885: Add file_type to DataFile to support deletion file
Posted by GitBox <gi...@apache.org>.
prodeezy commented on a change in pull request #885: Add file_type to DataFile to support deletion file
URL: https://github.com/apache/incubator-iceberg/pull/885#discussion_r404399830
##########
File path: core/src/main/java/org/apache/iceberg/GenericDataFile.java
##########
@@ -160,6 +161,14 @@ public GenericDataFile(org.apache.avro.Schema avroSchema) {
this.keyMetadata = ByteBuffers.toByteArray(keyMetadata);
}
+ GenericDataFile(String filePath, FileFormat format, PartitionData partition,
+ long fileSizeInBytes, Metrics metrics,
+ ByteBuffer keyMetadata, List<Long> splitOffsets, Integer fileType) {
+ this(filePath, format, partition, fileSizeInBytes, metrics, splitOffsets);
Review comment:
this can be ..
```
this(filePath, format, partition, fileSizeInBytes, metrics, keyMetadata, splitOffsets);
this.fileType = fileType;
```
.. for better reuse of code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] chenjunjiedada commented on pull request #885: Add file_type to DataFile to support deletion file
Posted by GitBox <gi...@apache.org>.
chenjunjiedada commented on pull request #885:
URL: https://github.com/apache/incubator-iceberg/pull/885#issuecomment-618868693
@rdblue , Could you please help to take a look at this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] chenjunjiedada closed pull request #885: Add file_type to DataFile to support deletion file
Posted by GitBox <gi...@apache.org>.
chenjunjiedada closed pull request #885:
URL: https://github.com/apache/incubator-iceberg/pull/885
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] chenjunjiedada commented on pull request #885: Add file_type to DataFile to support deletion file
Posted by GitBox <gi...@apache.org>.
chenjunjiedada commented on pull request #885:
URL: https://github.com/apache/incubator-iceberg/pull/885#issuecomment-633395136
Close this due to duplicated with https://github.com/apache/incubator-iceberg/pull/1030
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org